Skip to content

Commit 689073d

Browse files
authoredJun 5, 2024··
✨ bring back query tests for node 21 (#5690)
1 parent 2803a2b commit 689073d

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed
 

‎.github/workflows/ci.yml

+1-10
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ jobs:
135135

136136
- name: Node.js 21.x
137137
node-version: "21.6"
138-
138+
139139
- name: Node.js 22.x
140140
node-version: "22.0"
141141

@@ -148,15 +148,6 @@ jobs:
148148
nvm install --default ${{ matrix.node-version }}
149149
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
150150
151-
- name: Configure npm
152-
run: |
153-
npm config set loglevel error
154-
if [[ "$(npm config get package-lock)" == "true" ]]; then
155-
npm config set package-lock false
156-
else
157-
npm config set shrinkwrap false
158-
fi
159-
160151
- name: Install npm module(s) ${{ matrix.npm-i }}
161152
run: npm install --save-dev ${{ matrix.npm-i }}
162153
if: matrix.npm-i != ''

‎.npmrc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
package-lock=false

‎test/support/utils.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,11 @@ function getMajorVersion(versionString) {
7777
}
7878

7979
function shouldSkipQuery(versionString) {
80-
// Temporarily skipping this test on 21 and 22
80+
// Temporarily skipping this test on 22
8181
// update this implementation to run on those release lines on supported versions once they exist
8282
// upstream tracking https://github.com/nodejs/node/pull/51719
8383
// express tracking issue: https://github.com/expressjs/express/issues/5615
8484
var majorsToSkip = {
85-
"21": true,
8685
"22": true
8786
}
8887
return majorsToSkip[getMajorVersion(versionString)]

0 commit comments

Comments
 (0)
Please sign in to comment.