Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: expressjs/cookie-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1dc306b0ebe86ab98521811cc090740b4bef48e7
Choose a base ref
...
head repository: expressjs/cookie-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d61e1e2f3f18efe8f94e5fad2886b48864d6c78
Choose a head ref

Commits on Mar 4, 2019

  1. docs: fix typos

    closes #50
    Tanja-4732 authored and dougwilson committed Mar 4, 2019
    Copy the full SHA
    26fd91a View commit details

Commits on May 20, 2019

  1. build: Node.js@6.17

    dougwilson committed May 20, 2019
    Copy the full SHA
    809df90 View commit details
  2. build: Node.js@8.16

    dougwilson committed May 20, 2019
    Copy the full SHA
    2bcefe1 View commit details
  3. build: Node.js@11.15

    dougwilson committed May 20, 2019
    Copy the full SHA
    3bdc7b0 View commit details

Commits on May 24, 2019

  1. build: eslint@5.16.0

    dougwilson committed May 24, 2019
    Copy the full SHA
    b73500a View commit details

Commits on May 27, 2019

  1. Copy the full SHA
    2d2b5ed View commit details

Commits on Jun 1, 2019

  1. Copy the full SHA
    16af8ad View commit details

Commits on Jun 12, 2019

  1. build: Node.js@10.16

    dougwilson committed Jun 12, 2019
    Copy the full SHA
    575fea4 View commit details
  2. Copy the full SHA
    188b47b View commit details

Commits on Jun 13, 2019

  1. build: mocha@6.1.4

    dougwilson committed Jun 13, 2019
    Copy the full SHA
    eef41aa View commit details
  2. build: supertest@4.0.2

    dougwilson committed Jun 13, 2019
    Copy the full SHA
    0629b5e View commit details

Commits on Jul 20, 2019

  1. Copy the full SHA
    d128bd6 View commit details
  2. build: mocha@6.2.0

    dougwilson committed Jul 20, 2019
    Copy the full SHA
    511e8e8 View commit details
  3. build: Node.js@12.6

    dougwilson committed Jul 20, 2019
    Copy the full SHA
    1472e30 View commit details

Commits on Aug 29, 2019

  1. Copy the full SHA
    1b414fd View commit details
  2. build: Node.js@12.9

    dougwilson committed Aug 29, 2019
    Copy the full SHA
    8d68166 View commit details

Commits on Sep 3, 2019

  1. build: eslint@6.3.0

    dougwilson committed Sep 3, 2019
    Copy the full SHA
    fe94238 View commit details
  2. Copy the full SHA
    122c49f View commit details

Commits on Oct 15, 2019

  1. build: Node.js@12.12

    dougwilson committed Oct 15, 2019
    Copy the full SHA
    0914d7a View commit details

Commits on Nov 14, 2019

  1. build: mocha@6.2.2

    dougwilson committed Nov 14, 2019
    Copy the full SHA
    955ae4c View commit details
  2. build: Node.js@10.17

    dougwilson committed Nov 14, 2019
    Copy the full SHA
    c02f3aa View commit details
  3. build: Node.js@12.13

    dougwilson committed Nov 14, 2019
    Copy the full SHA
    e21e407 View commit details

Commits on Jan 26, 2020

  1. build: eslint@6.8.0

    dougwilson committed Jan 26, 2020
    Copy the full SHA
    2ad47b7 View commit details
  2. Copy the full SHA
    81a5599 View commit details
  3. Copy the full SHA
    f4e024f View commit details
  4. build: mocha@7.0.0

    dougwilson committed Jan 26, 2020
    Copy the full SHA
    dc05375 View commit details

Commits on Feb 2, 2020

  1. build: Node.js@8.17

    dougwilson committed Feb 2, 2020
    Copy the full SHA
    e2d7b43 View commit details
  2. build: Node.js@10.18

    dougwilson committed Feb 2, 2020
    Copy the full SHA
    e4249cd View commit details
  3. build: Node.js@12.14

    dougwilson committed Feb 2, 2020
    Copy the full SHA
    f0b3ea4 View commit details
  4. build: mocha@7.0.1

    dougwilson committed Feb 2, 2020
    Copy the full SHA
    0bc799c View commit details
  5. Copy the full SHA
    9599b48 View commit details

Commits on Mar 13, 2020

  1. deps: cookie@0.4.0

    dougwilson committed Mar 13, 2020
    Copy the full SHA
    29aaf38 View commit details
  2. Copy the full SHA
    6c3541c View commit details
  3. Copy the full SHA
    a7fae23 View commit details
  4. build: mocha@7.1.0

    dougwilson committed Mar 13, 2020
    Copy the full SHA
    76f6367 View commit details
  5. Copy the full SHA
    0ec7045 View commit details
  6. docs: hard wrap lines

    dougwilson committed Mar 13, 2020
    Copy the full SHA
    43dde8f View commit details

Commits on Mar 15, 2020

  1. Copy the full SHA
    51f99b9 View commit details
  2. Copy the full SHA
    ae6ec73 View commit details
  3. build: Node.js@10.19

    dougwilson committed Mar 15, 2020
    Copy the full SHA
    3dc38b6 View commit details
  4. build: Node.js@12.16

    dougwilson committed Mar 15, 2020
    Copy the full SHA
    78003f1 View commit details
  5. Copy the full SHA
    ff3a789 View commit details
  6. Copy the full SHA
    747f5a1 View commit details
  7. Copy the full SHA
    562fe89 View commit details
  8. 1.4.5

    dougwilson committed Mar 15, 2020
    Copy the full SHA
    2fea3f1 View commit details

Commits on Apr 6, 2020

  1. Copy the full SHA
    c62692c View commit details
  2. Copy the full SHA
    cd881a5 View commit details

Commits on Apr 8, 2020

  1. Copy the full SHA
    de30a49 View commit details

Commits on Apr 12, 2020

  1. build: mocha@7.1.1

    dougwilson committed Apr 12, 2020
    Copy the full SHA
    e7f7a57 View commit details
  2. build: Node.js@10.20

    dougwilson committed Apr 12, 2020
    Copy the full SHA
    0dbe8da View commit details
Showing with 432 additions and 156 deletions.
  1. +8 −1 .eslintrc.yml
  2. +214 −0 .github/workflows/ci.yml
  3. +73 −0 .github/workflows/scorecard.yml
  4. +1 −0 .gitignore
  5. +0 −89 .travis.yml
  6. +35 −1 HISTORY.md
  7. +53 −19 README.md
  8. +15 −16 package.json
  9. +33 −30 test/cookieParser.js
9 changes: 8 additions & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
root: true
extends: standard
extends:
- standard
- plugin:markdown/recommended
plugins:
- markdown
overrides:
- files: '**/*.md'
processor: 'markdown/markdown'
214 changes: 214 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,214 @@
name: ci

on:
- pull_request
- push

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
name:
- Node.js 0.8
- Node.js 0.10
- Node.js 0.12
- io.js 1.x
- io.js 2.x
- io.js 3.x
- Node.js 4.x
- Node.js 5.x
- Node.js 6.x
- Node.js 7.x
- Node.js 8.x
- Node.js 9.x
- Node.js 10.x
- Node.js 11.x
- Node.js 12.x
- Node.js 13.x
- Node.js 14.x
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x
- Node.js 22.x

include:
- name: Node.js 0.8
node-version: "0.8"
npm-i: mocha@2.5.3 supertest@1.1.0
npm-rm: nyc

- name: Node.js 0.10
node-version: "0.10"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0

- name: Node.js 0.12
node-version: "0.12"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0

- name: io.js 1.x
node-version: "1.8"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0

- name: io.js 2.x
node-version: "2.5"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0

- name: io.js 3.x
node-version: "3.3"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0

- name: Node.js 4.x
node-version: "4.9"
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2

- name: Node.js 5.x
node-version: "5.12"
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2

- name: Node.js 6.x
node-version: "6.17"
npm-i: mocha@6.2.2 nyc@14.1.1 supertest@3.4.2

- name: Node.js 7.x
node-version: "7.10"
npm-i: mocha@6.2.2 nyc@14.1.1

- name: Node.js 8.x
node-version: "8.17"
npm-i: mocha@7.2.0 nyc@14.1.1

- name: Node.js 9.x
node-version: "9.11"
npm-i: mocha@7.2.0 nyc@14.1.1

- name: Node.js 10.x
node-version: "10.24"
npm-i: mocha@8.4.0

- name: Node.js 11.x
node-version: "11.15"
npm-i: mocha@8.4.0

- name: Node.js 12.x
node-version: "12.22"

- name: Node.js 13.x
node-version: "13.14"

- name: Node.js 14.x
node-version: "14.19"

- name: Node.js 15.x
node-version: "15.14"

- name: Node.js 16.x
node-version: "16.14"

- name: Node.js 17.x
node-version: "17.6"

- name: Node.js 18.x
node-version: "18.14"

- name: Node.js 19.x
node-version: "19.6"

- name: Node.js 20.x
node-version: "20.12"

- name: Node.js 21.x
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.0"

steps:
- uses: actions/checkout@v4

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
run: |
nvm install --default ${{ matrix.node-version }}
if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
nvm install --alias=npm 0.10
nvm use ${{ matrix.node-version }}
sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
npm config set strict-ssl false
fi
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
- name: Configure npm
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi
- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
if: matrix.npm-rm != ''

- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''

- name: Setup Node.js version-specific dependencies
shell: bash
run: |
# eslint for linting
# - remove on Node.js < 10
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
grep -E '^eslint(-|$)' | \
sort -r | \
xargs -n1 npm rm --silent --save-dev
fi
- name: Install Node.js dependencies
run: npm install

- name: List environment
id: list_env
shell: bash
run: |
echo "node@$(node -v)"
echo "npm@$(npm -v)"
npm -s ls ||:
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print "" $2 "=" $3 }' >> "$GITHUB_OUTPUT"
- name: Run tests
shell: bash
run: |
if npm -ps ls nyc | grep -q nyc; then
npm run test-ci
else
npm test
fi
- name: Lint code
if: steps.list_env.outputs.eslint != ''
run: npm run lint

- name: Collect code coverage
uses: coverallsapp/github-action@master
if: steps.list_env.outputs.nyc != ''
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.test_number }}
parallel: true

coverage:
needs: test
runs-on: ubuntu-latest
steps:
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
73 changes: 73 additions & 0 deletions .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
# This workflow uses actions that are not certified by GitHub. They are provided
# by a third-party and are governed by separate terms of service, privacy
# policy, and support documentation.

name: Scorecard supply-chain security

on:
# For Branch-Protection check. Only the default branch is supported. See
# https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection
branch_protection_rule:
# To guarantee Maintained check is occasionally updated. See
# https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained
schedule:
- cron: '16 21 * * 1'
push:
branches: [ "master" ]

# Declare default permissions as read only.
permissions: read-all

jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-latest
permissions:
# Needed to upload the results to code-scanning dashboard.
security-events: write
# Needed to publish results and get a badge (see publish_results below).
id-token: write
# Uncomment the permissions below if installing in a private repository.
# contents: read
# actions: read

steps:
- name: "Checkout code"
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.2
with:
persist-credentials: false

- name: "Run analysis"
uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736 # v2.3.1
with:
results_file: results.sarif
results_format: sarif
# (Optional) "write" PAT token. Uncomment the `repo_token` line below if:
# - you want to enable the Branch-Protection check on a *public* repository, or
# - you are installing Scorecard on a *private* repository
# To create the PAT, follow the steps in https://github.com/ossf/scorecard-action#authentication-with-pat.
# repo_token: ${{ secrets.SCORECARD_TOKEN }}

# Public repositories:
# - Publish results to OpenSSF REST API for easy access by consumers
# - Allows the repository to include the Scorecard badge.
# - See https://github.com/ossf/scorecard-action#publishing-results.
# For private repositories:
# - `publish_results` will always be set to `false`, regardless
# of the value entered here.
publish_results: true

# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
with:
name: SARIF file
path: results.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@2f93e4319b2f04a2efc38fa7f78bd681bc3f7b2f # v2.23.2
with:
sarif_file: results.sarif
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.nyc_output
coverage
node_modules
package-lock.json
89 changes: 0 additions & 89 deletions .travis.yml

This file was deleted.

Loading