Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"checkError" incorrectly for used nonce. #2846

Closed
ricmoo opened this issue Mar 26, 2022 Discussed in #2845 · 7 comments
Closed

"checkError" incorrectly for used nonce. #2846

ricmoo opened this issue Mar 26, 2022 Discussed in #2845 · 7 comments
Labels
bug Verified to be an issue.

Comments

@ricmoo
Copy link
Member

ricmoo commented Mar 26, 2022

Discussed in #2845

Originally posted by timaiv March 26, 2022
ethers.js check "nonce too low".
Currently alchemy and infura nodes return "nonce is too low".

@ricmoo ricmoo added investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. labels Mar 26, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Mar 26, 2022

I’ll look into this in the morning.

@ricmoo
Copy link
Member Author

ricmoo commented Apr 12, 2022

I've tested this on Ropsten, and the string I get is still "nonce too low", there is no "is". Is this something that is on only mainnet? I'd rather confirm this is the case before spending real ether to validate.

@timaiv
Copy link

timaiv commented Apr 13, 2022

I've tested this on Ropsten, and the string I get is still "nonce too low", there is no "is". Is this something that is on only mainnet? I'd rather confirm this is the case before spending real ether to validate.

I have tested on kovan.
OE nodes return "nonce is too low".
https://github.com/openethereum/openethereum/blob/main/crates/rpc/src/v1/helpers/errors.rs#L376

Geth nodes return "nonce too low".
https://github.com/ethereum/go-ethereum/blob/master/core/error.go#L48

@ricmoo ricmoo added bug Verified to be an issue. and removed investigate Under investigation and may be a bug. labels Apr 13, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Apr 13, 2022

I was able to reproduce on Kovan and will get a fix out today.

Thanks! :)

@ricmoo
Copy link
Member Author

ricmoo commented Apr 14, 2022

This has been fixed in 5.6.4. Please try it out and let me know if you have any issues.

Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Apr 14, 2022
@timaiv
Copy link

timaiv commented Apr 14, 2022

This has been fixed in 5.6.4. Please try it out and let me know if you have any issues.

Thanks! :)

Please, update also REPLACEMENT_UNDERPRICED for OE, in my libs:

if (message.match(/replacement transaction underpriced|Transaction gas price (supplied|\d+wei) is too low/)) {

https://github.com/openethereum/openethereum/blob/6c2d392d867b058ff867c4373e40850ca3f96969/crates/rpc/src/v1/helpers/errors.rs#L377

ethers.js supports only GETH version
https://github.com/ethereum/go-ethereum/blob/master/core/tx_pool.go#L74

@ricmoo ricmoo added on-deck This Enhancement or Bug is currently being worked on. and removed fixed/complete This Bug is fixed or Enhancement is complete and published. labels Apr 22, 2022
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label May 3, 2022
@ricmoo
Copy link
Member Author

ricmoo commented May 3, 2022

I've added the change for REPLACEMENT_TRANSACITON too.

Thanks! :)

@ricmoo ricmoo closed this as completed May 3, 2022
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue.
Projects
None yet
Development

No branches or pull requests

2 participants