Skip to content

Commit d6439b3

Browse files
author
Kai Cataldo
authoredMay 8, 2020
Fix: use global-import shelljs (#38)
* Fix: use global-import shelljs * Add comment
1 parent 3d05dc5 commit d6439b3

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed
 

‎lib/release-ops.js

+12-7
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,19 @@
55
* MIT License
66
*/
77

8+
/* global test, cat, rm, mv */
9+
810
"use strict";
911

1012
//------------------------------------------------------------------------------
1113
// Requirements
1214
//------------------------------------------------------------------------------
1315

16+
// TODO: Update to use non-global module to avoid prototype pollution.
17+
require("shelljs/global");
18+
1419
const fs = require("fs"),
1520
path = require("path"),
16-
shelljs = require("shelljs"),
1721
semver = require("semver"),
1822
GitHub = require("github-api"),
1923
dateformat = require("dateformat"),
@@ -44,7 +48,7 @@ function getPackageInfo() {
4448
* @private
4549
*/
4650
function validateSetup() {
47-
if (!shelljs.test("-f", "package.json")) {
51+
if (!test("-f", "package.json")) {
4852
console.error("Missing package.json file");
4953
ShellOps.exit(1);
5054
}
@@ -319,15 +323,16 @@ function writeChangelog(releaseInfo) {
319323
(`\n${releaseInfo.rawChangelog}\n`).toEnd("CHANGELOG.tmp");
320324

321325
// ensure there's a CHANGELOG.md file
322-
if (!shelljs.test("-f", "CHANGELOG.md")) {
326+
if (!test("-f", "CHANGELOG.md")) {
323327
fs.writeFileSync("CHANGELOG.md", "");
324328
}
325329

326330
// switch-o change-o
327-
fs.writeFileSync("CHANGELOG.md.tmp", shelljs.cat("CHANGELOG.tmp", "CHANGELOG.md"));
328-
shelljs.rm("CHANGELOG.tmp");
329-
shelljs.rm("CHANGELOG.md");
330-
shelljs.mv("CHANGELOG.md.tmp", "CHANGELOG.md");
331+
// `cat` returns a ShellString and `fs.writeFileSync` is throwing an error saying that this must be a String.
332+
fs.writeFileSync("CHANGELOG.md.tmp", cat("CHANGELOG.tmp", "CHANGELOG.md").toString());
333+
rm("CHANGELOG.tmp");
334+
rm("CHANGELOG.md");
335+
mv("CHANGELOG.md.tmp", "CHANGELOG.md");
331336
}
332337

333338
/**

0 commit comments

Comments
 (0)
Please sign in to comment.