Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
9
contributors
Commits on Jun 5, 2019
-
Chore: Upgrade to eslint-config-eslint@5.0.1 (#110)
* Chore: Upgrade to eslint-config-eslint@5.0.1 The prior config was still enforcing ES5 coding standards. The earliest supported version of Node.js is 6.14.0, so this lets us use all the nice ES6 features. * npm run lint -- --fix * assert.equal -> assert.strictEqual * Use block-scoped variable declarations * Use array spread operator
Commits on Oct 8, 2019
-
Fix: Support autofix at the very start of blocks (fixes #117) (#119)
Previously, if a rule added an autofix at index 0 of a code block, all code from the start of the markdown file until the start of that code block would be removed. Now, the autofix is applied as expected. Fixes lydell/eslint-plugin-simple-import-sort#22
Commits on Oct 9, 2019
-
-
Chore: Use GitHub Actions (#123)
* Chore: Use GitHub Actions * Lint source only once in CI This runs the tests against all supported major versions of Node.js, but we only need to lint the source code once.
Commits on Oct 22, 2019
-
Fix: Indent multiline fixes (fixes #120) (#124)
* Chore: Add failing test case for indent of multiline fixes If the replacement text of an autofix contains newlines, all lines but the first in the replacement text will unexpectedly have 0 indentation if a code block is indented. I guess not only the _range_ of fixes but also the _text_ of fixes need to be adjusted. If the code block is placed within a blockquote, a `>` character also needs to be inserted. This issue was found while investigating lydell/eslint-plugin-simple-import-sort#22. That plugin several lines of imports in one go. This means that most of the imports will have too little indentation after autofix if the code block is indented (such as when placed in a list). * Fix: Indent multiline fixes (fixes #120) * Add test for underindented multiline autofix * Add test for nested blockquote multiline autofix * Add comment explaining underintented line shift
Commits on Nov 1, 2019
-
Chore: Remove call to lint absent
Makefile.js(#129)In the process, add to the ignore file to explicitly exclude undesired; also lint additional file.
Commits on Nov 2, 2019
-
Upgrade: Update devDeps and change istanbul -> nyc (#130)
Update eslint-release, chai, mocha, and eslint devDeps. In process of updating, get plugins tests to work in anticipation of eslint 6.
Commits on Feb 24, 2020
Commits on Feb 28, 2020
-
Chore: Add npm version and build status badges (#139)
No need to have all the badges on eslint/eslint, but npm version and build status are handy.
-
Breaking: Drop support for Node.js v6 (refs #138) (#137)
The new processor API first shipped in ESLint v6, which requires at least Node.js v8.10.0. Since Node.js v8 left LTS maintenance two months ago, I considered dropping support for it as well and aligning with the supported engines in ESLint v7, but I don't see a compelling reason not to support ESLint v6.
Commits on Mar 1, 2020
-
GitHub Actions is working great and runs faster.
-
Chore: Use ES2018 object spread syntax (#141)
This syntax first shipped in Node.js v8.6.0 and removes a dependency on `object-assign`.
-
Breaking: Require ESLint v6 (#142)
The new processor API shipped in ESLint v6.
Commits on Mar 4, 2020
-
Chore: Update ESLint config and plugins (#143)
This matches ESLint configuration as of the last v6 release. Since this only affects devDependencies, it's a chore rather than an upgrade tag.
Commits on Mar 17, 2020
-
Docs: Explain use of --ext option in ESLint v7 (#146)
* Docs: Explain use of --ext option in ESLint v7 * Docs: Link additional lint targets RFC We don't have this in the docs on eslint.org yet, so the RFC seemed like the next best thing.
Commits on Apr 5, 2020
Commits on Apr 12, 2020
Commits on Aug 2, 2020
-
Fix: Don't require message end locations (fixes #112) (#154)
Issue #112 reported VSCode drawing squigglies all the way from the top of a file to a line in a code block with a syntax error rather than just squigglying the line with the syntax error. For messages that only specified start locations, the processor was adding `endLine: NaN`.
-
Docs: Add React example (#152)
* Docs: Add React example * Docs: Ignore lint errors in examples * Docs: Test examples report errors
Commits on Aug 10, 2020
Commits on Aug 13, 2020
-
New: Add rules to recommended config (#157)
It's basically what documentation suggests. One rule I would add, but in documentation only, is `"import/no-unresolved": "off"`
Commits on Aug 15, 2020
-
Docs: Add TypeScript example (#155)
* Docs: Add TypeScript example * WIP: Add tsconfig.json for type-aware linting It works on the first block but not the second. See diff for additional context. Any ideas? * Docs: Remove tsconfig.json and add type-aware rule note
-
Docs: Reference recommended config disabled rules (#159)
* Docs: Relocate recommended rule section in docs This is a cut-and-paste commit. I'm going to update these to reflect the recommended config and want to put them under the "Advanced Configuration" section. I did this in a precursor commit to make reviewing the actual textual diff easier in the next commit. * Docs: Reference recommended config disabled rules * Docs: Explain rules disabled in recommended config These borrow a snippet of text from the corresponding documentation in the readme. * Docs: Simplify wording Thanks to @ilyavolodin for the suggestions to start this off.
Commits on Aug 20, 2020
-
Build: Install example test dependencies in Jenkins (#160)
The 2.0.0-rc.0 release attempt failed when trying to run the examples' tests because their dependencies were never installed. In #152, I added an install step to the GitHub Actions workflow but not the Jenkins release flow. This change adds an `install-examples` npm script and calls it both from the GitHub Actions workflow and the `generate-.*release` scripts.
Commits on Nov 26, 2020
-
Chore: Automatically install example dependencies (#164)
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Commits on Dec 16, 2020
-
Chore: Switch to main for primary branch (fixes #161) (#165)
* Chore: Switch to main for primary branch (fixes #161) The only remaining string search results for "master" are URLs to other repositories. * Chore: Use latest eslint-release This should allow releasing from the `main` branch, which was part of the 3.1 release. The breaking changes in v2 and v3 dropped support for older Node versions on the release server. Since it's working in other eslint org packages, that's not a concern.
Commits on Dec 20, 2020
-
Fix: Ignore words in info string after syntax (fixes #166) (#167)
* Fix: Ignore words in info string after syntax (fixes #166) This was working correctly in v1 but stopped working when v2 switched to the new processor API. The generated filename was `0.js more words are ignored`. The test case for this was insufficiently strict: it asserted that the code block was extracted, which was sufficient with hard-coded extensions in v1, but it didn't assert the generated name was `0.js` now that we're taking the extension from the info string. Per CommonMark 0.29 [1]: > The line with the opening code fence may optionally contain some text > following the code fence; this is trimmed of leading and trailing > whitespace and called the info string. I've strengthened the tests for generated filename extensions and added a new test to ensure that leading whitespace is trimmed correctly. [1]: https://spec.commonmark.org/0.29/#info-string * Use replace instead of trimStart for Node.js 8.x * Ignore trailing whitespace in info strings Markdown info strings permit trimming both leading and trailing whitespace, so this shouldn't cause issues. `.trim()` is much nicer than a regex `.replace()`.
-
Fix: npm prepare script on Windows (refs #166) (#168)
* Chore: Test on Windows and macOS * Fix: npm prepare script on Windows (refs #166) The previous script worked on macOS and Linux, but I neglected to consider Windows. This wouldn't affect users thankfully, only developers, so the blast radius would have been small had it not been caught. Now that we're testing on Windows, future bugs like this should be caught. I'm out of ideas for doing this entirely inside npm scripts, so I broke down and did it in JS. * Chore: Increase test timeout for Windows and macOS runners They occasionally exhibit extremely slow filesystem performance. * Add npm-prepare script JSDoc header
Commits on Jan 31, 2021
Commits on Feb 14, 2021
-
Docs: Remove prerelease README notes (#173)
I plan to release v2.0.0 this weekend, so these prerelease-specific notes can finally be removed from the README!
Commits on Mar 30, 2021
-
Fix: More reliable comment attachment (fixes #76) (#177)
Comment attachment was sensitive to whitespace around the code block and preceding comments. In some cases, the parser would place comments as descendants of code blocks' preceding sibling nodes. However, a depth-first traversal of the tree will still encounter the comments in linear order, which is sufficient for our purposes.
-
Docs: improve jsdoc, better for typings (#182)
* Docs: improve jsdoc, better for typings * docs: improve jsdoc without @types/*
There are no files selected for viewing
This file was deleted.