Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release-please #170

Merged
merged 5 commits into from
Jan 19, 2024
Merged

chore: add release-please #170

merged 5 commits into from
Jan 19, 2024

Conversation

aladdin-add
Copy link

No description provided.

Comment on lines 18 to 19
package-name: 'espree'
pull-request-title-pattern: 'chore: release${component} ${version}'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the default here is fine 🤔
Its probably the same for the change logs

This is the default:
image

pull-requests: write
id-token: write
steps:
- uses: google-github-actions/release-please-action@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth using v4 so we dont start behind 👀

.github/workflows/release-please.yml Outdated Show resolved Hide resolved
.github/workflows/release-please.yml Outdated Show resolved Hide resolved
.github/workflows/release-please.yml Outdated Show resolved Hide resolved
@aladdin-add aladdin-add marked this pull request as ready for review January 19, 2024 02:42
@aladdin-add aladdin-add merged commit fc77da2 into master Jan 19, 2024
17 checks passed
@aladdin-add aladdin-add deleted the aladdin-add-patch-1 branch January 19, 2024 02:46
@aladdin-add
Copy link
Author

It's still in the prerelease process for v17, so it may still need to be configured. Until then I'll still use release-it for releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants