Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint-community/eslint-plugin-n
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v17.8.0
Choose a base ref
...
head repository: eslint-community/eslint-plugin-n
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v17.8.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Jun 6, 2024

  1. fix: hashbang + eslint v8 compat issue (#290) 

    fix: hashbang + eslint v8 compat issue
    @aladdin-add
    aladdin-add authored Jun 6, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e82974f View commit details

  2. chore(master): release 17.8.1 (#291) 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Jun 6, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    988bdd4 View commit details
Showing with 11 additions and 3 deletions.
  1. +1 −1 .github/release-please/manifest.json
  2. +8 −0 CHANGELOG.md
  3. +1 −1 lib/rules/hashbang.js
  4. +1 −1 package.json
2 changes: 1 addition & 1 deletion .github/release-please/manifest.json
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{".":"17.8.0"}
{".":"17.8.1"}
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [17.8.1](https://github.com/eslint-community/eslint-plugin-n/compare/v17.8.0...v17.8.1) (2024-06-06)


### 🩹 Fixes

* hashbang + eslint v8 compat issue ([e82974f](https://github.com/eslint-community/eslint-plugin-n/commit/e82974fc724e4a410f85459f4cd3e5367939cc9c))
* hashbang + eslint v8 compat issue ([#290](https://github.com/eslint-community/eslint-plugin-n/issues/290)) ([e82974f](https://github.com/eslint-community/eslint-plugin-n/commit/e82974fc724e4a410f85459f4cd3e5367939cc9c))

## [17.8.0](https://github.com/eslint-community/eslint-plugin-n/compare/v17.7.0...v17.8.0) (2024-06-05)


2 changes: 1 addition & 1 deletion lib/rules/hashbang.js
View file
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ function isNodeShebang(shebang, executableName) {
* @returns {string}
*/
function getExpectedExecutableName(context) {
const extension = path.extname(context.filename)
const extension = path.extname(context.filename ?? context.getFilename())
/** @type {{ executableMap: Record<string, string> }} */
const { executableMap = {} } = context.options?.[0] ?? {}

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-n",
"version": "17.8.0",
"version": "17.8.1",
"description": "Additional ESLint's rules for Node.js",
"engines": {
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"