.github/release-please/manifest.json

@@ -1 +1 @@
-{".":"17.10.2"}
+{".":"17.10.3"}

CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [17.10.3](https://github.com/eslint-community/eslint-plugin-n/compare/v17.10.2...v17.10.3) (2024-09-18)
+
+
+### 🩹 Fixes
+
+* Use our data set to work out if a module is a node module ([#338](https://github.com/eslint-community/eslint-plugin-n/issues/338)) ([6a1b2c5](https://github.com/eslint-community/eslint-plugin-n/commit/6a1b2c5606f0c6a37b38b60d780df8698db22a87))
+
+
+### 📚 Documentation
+
+* **process-exit-as-throw:** update wording ([#323](https://github.com/eslint-community/eslint-plugin-n/issues/323)) ([e5e758e](https://github.com/eslint-community/eslint-plugin-n/commit/e5e758ea0cd238220127ae7bcbd967f1d8920f28))
+
 ## [17.10.2](https://github.com/eslint-community/eslint-plugin-n/compare/v17.10.1...v17.10.2) (2024-08-05)
 
 

docs/rules/process-exit-as-throw.md

@@ -16,9 +16,9 @@ function foo(a) {
 }
 ```
 
-ESLint does not address `process.exit()` as stop in code path analysis, then [consistent-return] rule will warn the above code.
+ESLint does not mark code after `process.exit()` calls as unreachable like it does with `throw` and `return` expressions, meaning rules like [consistent-return] will still warn.
 
-If you turn this rule on, ESLint comes to address `process.exit()` as throw in code path analysis. So, above code will get expected code path.
+This rule overrides the default code path analyzer so that code after `process.exit()` calls are marked as unreachable, meaning code like the above will not trigger warnings.
 
 This rule itself never warn code.
 

lib/rules/prefer-node-protocol.js

@@ -4,12 +4,22 @@
  */
 "use strict"
 
-const { isBuiltin } = require("node:module")
 const getConfiguredNodeVersion = require("../util/get-configured-node-version")
 const getSemverRange = require("../util/get-semver-range")
 const visitImport = require("../util/visit-import")
 const visitRequire = require("../util/visit-require")
 const mergeVisitorsInPlace = require("../util/merge-visitors-in-place")
+const {
+    NodeBuiltinModules,
+} = require("../unsupported-features/node-builtins.js")
+
+/**
+ * @param {string} name The name of the node module
+ * @returns {boolean}
+ */
+function isBuiltin(name) {
+    return Object.hasOwn(NodeBuiltinModules, name)
+}
 
 const messageId = "preferNodeProtocol"
 

package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-n",
-    "version": "17.10.2",
+    "version": "17.10.3",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": "^18.18.0 || ^20.9.0 || >=21.1.0"

tests/lib/rules/prefer-node-protocol.js

@@ -33,6 +33,8 @@ new RuleTester({
                 const fs = await import(\`fs\`);
             }
         `,
+        // punycode has no `node:` equivelent
+        'import "punycode";',
         'import "punycode/";',
         // https://bun.sh/docs/runtime/bun-apis
         'import "bun";',