.github/ISSUE_TEMPLATE/non-rule-change.yml

@@ -0,0 +1,47 @@
+name: "\U0001F680 Request a change (not rule-related)"
+description: "Request a change that is not a bug fix, rule change, or new rule"
+title: "Change Request: (fill in)"
+labels:
+  - enhancement
+  - core
+body:
+- type: markdown
+  attributes:
+    value: By opening an issue, you agree to abide by the [Open JS Foundation Code of Conduct](https://eslint.org/conduct).
+- type: input
+  attributes:
+    label: eslint-plugin-n version
+    description: |
+      What version of eslint-plugin-n are you currently using?
+    placeholder: |
+      e.g. v16.0.0
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: What problem do you want to solve?
+    description: |
+      Please explain your use case in as much detail as possible.
+    placeholder: |
+      ESLint currently...
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: What do you think is the correct solution?
+    description: |
+      Please explain how you'd like to change to address the problem.
+    placeholder: |
+      I'd like to...
+  validations:
+    required: true
+- type: checkboxes
+  attributes:
+    label: Participation
+    options:
+      - label: I am willing to submit a pull request for this change.
+        required: false
+- type: textarea
+  attributes:
+    label: Additional comments
+    description: Is there anything else that's important for the team to know?

lib/rules/no-callback-literal.js

@@ -62,7 +62,8 @@ function couldBeError(node) {
         case "TaggedTemplateExpression":
         case "YieldExpression":
             return true // possibly an error object.
-
+        case "Literal":
+            return node.value == null
         case "AssignmentExpression":
             return couldBeError(node.right)
 
@@ -76,8 +77,7 @@ function couldBeError(node) {
 
         case "ConditionalExpression":
             return couldBeError(node.consequent) || couldBeError(node.alternate)
-
         default:
-            return node.value === null
+            return true // assuming unknown nodes can be error objects.
     }
 }

package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-n",
-    "version": "16.6.0",
+    "version": "16.6.1",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": ">=16.0.0"
@@ -31,10 +31,10 @@
         "@types/eslint": "^8.44.6",
         "@typescript-eslint/parser": "^5.60.0",
         "esbuild": "^0.18.7",
-        "eslint": "^8.53.0",
+        "eslint": "^8.56.0",
         "eslint-config-prettier": "^8.8.0",
         "eslint-doc-generator": "^1.6.1",
-        "eslint-plugin-eslint-plugin": "^5.1.0",
+        "eslint-plugin-eslint-plugin": "^5.2.1",
         "eslint-plugin-n": "file:.",
         "fast-glob": "^3.2.12",
         "husky": "^8.0.3",

tests/lib/rules/callback-return.js

@@ -6,8 +6,9 @@
 
 const RuleTester = require("eslint").RuleTester
 const rule = require("../../../lib/rules/callback-return")
+const ruleTester = new RuleTester({ env: { node: true, es6: true } })
 
-new RuleTester().run("callback-return", rule, {
+ruleTester.run("callback-return", rule, {
     valid: [
         // callbacks inside of functions should return
         "function a(err) { if (err) return callback (err); }",
@@ -40,25 +41,20 @@ new RuleTester().run("callback-return", rule, {
         // arrow functions
         {
             code: "var x = err => { if (err) { callback(); return; } }",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "var x = err => callback(err)",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "var x = err => { setTimeout( () => { callback(); }); }",
-            parserOptions: { ecmaVersion: 6 },
         },
 
         // classes
         {
             code: "class x { horse() { callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
         },
         {
             code: "class x { horse() { if (err) { return callback(); } callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
         },
 
         // options (only warns with the correct callback name)
@@ -188,7 +184,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = (err) => { if (err) { callback (err); } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -200,7 +195,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = { x(err) { if (err) { callback (err); } } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -223,7 +217,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var x = { x(err) { if (err) { callback && callback (err); } } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -268,7 +261,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "var a = (err) => { callback (err); callback(); }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -302,7 +294,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "class x { horse() { if (err) { callback(); } callback(); } } ",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",
@@ -344,7 +335,6 @@ new RuleTester().run("callback-return", rule, {
         },
         {
             code: "() => { if (x) { callback(); } }",
-            parserOptions: { ecmaVersion: 6 },
             errors: [
                 {
                     messageId: "missingReturn",