Skip to content

Commit caab777

Browse files
authoredMar 20, 2024··
fix: prefer-node-protocol: not first target (#204)
1 parent 8327d11 commit caab777

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed
 

‎lib/rules/prefer-node-protocol.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ module.exports = {
124124
!isBuiltinModule(value) ||
125125
!isBuiltinModule(`node:${value}`)
126126
) {
127-
return
127+
continue
128128
}
129129

130130
context.report({

‎tests/lib/rules/prefer-node-protocol.js

+11
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,17 @@ new RuleTester({
191191
output: "const fs = require('node:fs/promises')",
192192
errors: ["Prefer `node:fs/promises` over `fs/promises`."],
193193
},
194+
{
195+
code: `
196+
const express = require('express');
197+
const fs = require('fs/promises');
198+
`,
199+
output: `
200+
const express = require('express');
201+
const fs = require('node:fs/promises');
202+
`,
203+
errors: ["Prefer `node:fs/promises` over `fs/promises`."],
204+
},
194205

195206
// check enabling by supported Node.js versions
196207
{

0 commit comments

Comments
 (0)
Please sign in to comment.