feat: upgrade typescript-eslint (#53)

Author: whxaxes

.github/workflows/nodejs.yml

@@ -0,0 +1,31 @@
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        node-version: [10.x, 12.x]
+        os: [ubuntu-latest, windows-latest, macos-latest]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm i -g npminstall && npminstall
+    - run: npm run ci
+      env:
+        CI: true

.travis.yml

@@ -1,4 +1,4 @@
-sudo: false
+
 language: node_js
 node_js:
   - '10'

lib/rules/typescript.js

@@ -16,6 +16,21 @@ module.exports = {
       markers: [ '*!', '/' ],
     }],
 
+    /**
+     * @see https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-use-before-define.md
+     */
+    'no-use-before-define': 'off',
+    '@typescript-eslint/no-use-before-define': [ 'error', {
+      functions: false,
+      classes: true,
+    }],
+
+    /**
+     * @see https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-useless-constructor.md
+     */
+    'no-useless-constructor': 'off',
+    '@typescript-eslint/no-useless-constructor': [ 'error' ],
+
     /**
      * An empty interface is equivalent to its supertype
      * @see https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-empty-interface.md

package.json

@@ -12,8 +12,8 @@
     "lib"
   ],
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.0.0",
-    "@typescript-eslint/parser": "^2.0.0",
+    "@typescript-eslint/eslint-plugin": "^3.0.0",
+    "@typescript-eslint/parser": "^3.0.0",
     "babel-eslint": "^8.2.6",
     "eslint-plugin-eggache": "^1.0.0",
     "eslint-plugin-import": "^2.14.0",

test/fixtures/ts-app/constructor/correct.ts

@@ -0,0 +1,6 @@
+export class MyClass {
+  constructor(
+    public a: number,
+    public b: string,
+  ) {}
+}

test/fixtures/ts-app/constructor/not-correct.ts

@@ -0,0 +1,3 @@
+export class MyClass {
+  constructor() {}
+}

test/fixtures/ts-app/no-undef/correct.ts

@@ -0,0 +1,9 @@
+interface IFSMTransition<T extends string> {
+  name: string;
+  from: T[];
+  to: T;
+}
+
+type IFSMTransitions<T extends string> = IFSMTransition<T>[];
+
+export default IFSMTransitions;

test/fixtures/ts-app/no-use-before-define/correct.ts

@@ -0,0 +1,10 @@
+class ABC {
+
+}
+
+const instance = new ABC();
+testABC(instance);
+
+function testABC(abc: ABC) {
+  console.info(abc);
+}

test/fixtures/ts-app/no-use-before-define/not-correct.ts

@@ -0,0 +1,10 @@
+const instance = new ABC();
+testABC(instance);
+
+function testABC(abc: ABC) {
+  console.info(abc);
+}
+
+class ABC {
+
+}

test/fixtures/ts-app/semi/semi.ts

@@ -1 +1,2 @@
 export const abc = 123;
+export interface SPI {}

test/ts.test.js

@@ -100,7 +100,7 @@ describe('test/ts.test.js', () => {
 
     it('should success with members', () => {
       return coffee.spawn('eslint', [ './align/members.ts' ], { cwd })
-        .debug()
+        // .debug()
         .expect('code', 0)
         .end();
     });
@@ -122,15 +122,15 @@ describe('test/ts.test.js', () => {
 
     it('should fail with parameters', () => {
       return coffee.spawn('eslint', [ './align/parameters-error.ts' ], { cwd })
-        .debug()
+        // .debug()
         .expect('stdout', /indent/)
         .expect('code', 1)
         .end();
     });
 
     it('should success with statements', () => {
       return coffee.spawn('eslint', [ './align/statements.ts' ], { cwd })
-        .debug()
+        // .debug()
         .expect('code', 0)
         .end();
     });
@@ -159,4 +159,47 @@ describe('test/ts.test.js', () => {
         .end();
     });
   });
+
+  describe('no-useless-constructor', () => {
+    it('should success', () => {
+      return coffee.spawn('eslint', [ './constructor/correct.ts' ], { cwd })
+        // .debug()
+        .expect('code', 0)
+        .end();
+    });
+
+    it('should fail', () => {
+      return coffee.spawn('eslint', [ './constructor/not-correct.ts' ], { cwd })
+        // .debug()
+        .expect('code', 1)
+        .expect('stdout', /@typescript-eslint\/no-useless-constructor/)
+        .end();
+    });
+  });
+
+  describe('no-use-before-define', () => {
+    it('should success', () => {
+      return coffee.spawn('eslint', [ './no-use-before-define/correct.ts' ], { cwd })
+        // .debug()
+        .expect('code', 0)
+        .end();
+    });
+
+    it('should fail', () => {
+      return coffee.spawn('eslint', [ './no-use-before-define/not-correct.ts' ], { cwd })
+        // .debug()
+        .expect('code', 1)
+        .expect('stdout', /@typescript-eslint\/no-use-before-define/)
+        .end();
+    });
+  });
+
+  describe('no-undef', () => {
+    it('should success', () => {
+      return coffee.spawn('eslint', [ './no-undef/correct.ts' ], { cwd })
+        // .debug()
+        .expect('code', 0)
+        .end();
+    });
+  });
 });