fix: unused vars rule (#50)

* fix: unused-vars is now valid

* chore: update CI generated config

* feat: turn on unused-vars check

* chore: force CI refresh

* feat: unused-vars should check local variables only

* fix: update trailing comma test case

Author: sang4lv

.travis.yml

@@ -1,7 +1,6 @@
 sudo: false
 language: node_js
 node_js:
-  - '8'
   - '10'
   - '12'
 before_install:

appveyor.yml

@@ -1,6 +1,5 @@
 environment:
   matrix:
-    - nodejs_version: '8'
     - nodejs_version: '10'
     - nodejs_version: '12'
 

lib/rules/typescript.js

@@ -26,7 +26,11 @@ module.exports = {
      * Variables that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring
      * @see https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unused-vars.md
      */
-    '@typescript-eslint/no-unused-vars': 'off',
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': [ 'error', {
+      vars: 'local',
+      args: 'after-used',
+    }],
 
     /**
      * Enforce camelCase naming convention

test/fixtures/ts-app/align/arguments.ts

@@ -1,3 +1,3 @@
 setTimeout(() => {
-
+  console.log('');
 }, 200);

test/fixtures/ts-app/align/elements.ts

@@ -1,4 +1,4 @@
-const foo = [
+export const foo = [
   1,
   2,
 ];

test/fixtures/ts-app/align/parameters-error.ts

@@ -1,4 +1,8 @@
 function bar(
   a: string,
    b: string
-) {}
+) {
+  console.log(a, b);
+}
+
+export { bar };

test/fixtures/ts-app/align/parameters.ts

@@ -4,3 +4,5 @@ function bar(
 ) {
   console.info(a, b);
 }
+
+export { bar };

test/fixtures/ts-app/align/statements.ts

@@ -1,2 +1,4 @@
 const foo1 = 1;
 const bar1 = 2;
+
+export { foo1, bar1 };

test/fixtures/ts-app/comma/trailing-comma.ts

@@ -16,11 +16,12 @@ function foo2(
 }
 
 import {
-  a,
-  b,
-} from 'egg';
+  fork,
+  spawn,
+} from 'coffee';
 
 export {
-  a,
-  b,
-} from 'egg';
+  Rule,
+} from 'coffee';
+
+export { foo2, fork, spawn };

test/fixtures/ts-app/reference/unused-vars.ts

@@ -0,0 +1 @@
+import { abc } from './semi/semi';

test/ts.test.js

@@ -151,5 +151,12 @@ describe('test/ts.test.js', () => {
         .expect('code', 0)
         .end();
     });
+
+    it('should success with unused variables', () => {
+      return coffee.spawn('eslint', [ './reference/unused-vars.ts' ], { cwd })
+        // .debug()
+        .expect('code', 1)
+        .end();
+    });
   });
 });