Skip to content

Commit 384557b

Browse files
authoredFeb 20, 2024··
Update WorkspaceEdit metadata typing (#13395)
Fixes #13355 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
1 parent c9bbfe5 commit 384557b

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed
 

‎packages/plugin-ext/src/plugin/types-impl.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1869,13 +1869,13 @@ export class WorkspaceEdit implements theia.WorkspaceEdit {
18691869
}
18701870

18711871
set(uri: URI, edits: ReadonlyArray<TextEdit | SnippetTextEdit>): void;
1872-
set(uri: URI, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata]>): void;
1872+
set(uri: URI, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void;
18731873
set(uri: URI, edits: ReadonlyArray<NotebookEdit>): void;
1874-
set(uri: URI, edits: ReadonlyArray<[NotebookEdit, theia.WorkspaceEditEntryMetadata]>): void;
1874+
set(uri: URI, edits: ReadonlyArray<[NotebookEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void;
18751875

18761876
set(uri: URI, edits: ReadonlyArray<TextEdit | SnippetTextEdit
1877-
| NotebookEdit | [NotebookEdit, theia.WorkspaceEditEntryMetadata]
1878-
| [TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata]>): void {
1877+
| NotebookEdit | [NotebookEdit, theia.WorkspaceEditEntryMetadata | undefined]
1878+
| [TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void {
18791879
if (!edits) {
18801880
// remove all text edits for `uri`
18811881
for (let i = 0; i < this._edits.length; i++) {

‎packages/plugin/src/theia.d.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -10281,15 +10281,7 @@ export module '@theia/plugin' {
1028110281
* @param uri A resource identifier.
1028210282
* @param edits An array of edits.
1028310283
*/
10284-
set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata]>): void;
10285-
10286-
/**
10287-
* Set (and replace) text edits or snippet edits with metadata for a resource.
10288-
*
10289-
* @param uri A resource identifier.
10290-
* @param edits An array of edits.
10291-
*/
10292-
set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata]>): void;
10284+
set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata | undefined]>): void;
1029310285

1029410286
/**
1029510287
* Set (and replace) notebook edits for a resource.
@@ -10305,7 +10297,7 @@ export module '@theia/plugin' {
1030510297
* @param uri A resource identifier.
1030610298
* @param edits An array of edits.
1030710299
*/
10308-
set(uri: Uri, edits: ReadonlyArray<[NotebookEdit, WorkspaceEditEntryMetadata]>): void;
10300+
set(uri: Uri, edits: ReadonlyArray<[NotebookEdit, WorkspaceEditEntryMetadata | undefined]>): void;
1030910301

1031010302
/**
1031110303
* Get the text edits for a resource.

0 commit comments

Comments
 (0)
Please sign in to comment.