Skip to content

Commit d7cd274

Browse files
committedJan 5, 2023
Try wrap up PR
1 parent 042c4fa commit d7cd274

File tree

5 files changed

+28
-22
lines changed

5 files changed

+28
-22
lines changed
 

‎.github/workflows/release.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,9 @@ name: Release executable files for macOS
33
on:
44
workflow_dispatch:
55
inputs:
6-
version_digit:
7-
description: 'Version digit (major | minor | patch)'
6+
version:
7+
description: "Version to deploy assets for"
88
required: true
9-
default: 'patch'
10-
type: choice
11-
options:
12-
- major
13-
- minor
14-
- patch
159

1610
jobs:
1711
release:
@@ -31,26 +25,32 @@ jobs:
3125

3226
- name: Check out repository code
3327
uses: actions/checkout@v3
34-
28+
3529
- name: Use node
3630
uses: actions/setup-node@v3
3731
with:
3832
node-version: "14"
3933

4034
- name: Install dependencies
4135
run: npm install
42-
36+
4337
- name: Build
4438
run: npm run build
4539

40+
- name: Tell release-it to do the GitHub release here
41+
run:
42+
node -e 'const fs = require("fs"); const a = JSON.parse(fs.readFileSync("./.release-it.json", "utf8"));
43+
a.github.release = true; a.hooks["after:bump"] = a.hooks["_after:bump"]; a.hooks["after:release"] =
44+
a.hooks["_after:release"]; fs.writeFileSync("./.release-it.json", JSON.stringify(a))'
45+
4646
- name: Package
4747
run: |
4848
git config --global user.email "action@github.com"
4949
git config --global user.name "GitHub Action"
50-
npm run release -- ${{ github.event.inputs.version_digit }} --ci
50+
npm run release -- ${{ github.event.inputs.version }} --no-npm --ci
5151
5252
- name: Update homebrew/tap repo for new release
5353
shell: bash
5454
run: scripts/create-homebrew-tap-pr.sh
5555
env:
56-
VERSION: ${{ env.VERSION }}
56+
VERSION: ${{ env.VERSION }}

‎.release-it.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
2-
"github": {
3-
"release": true,
4-
"assets": "brew-distribution/*.zip"
5-
},
2+
"_": "CI will switch the release here to true",
3+
"github": { "release": false, "assets": "brew-distribution/*.zip" },
64
"buildCommand": "yarn package:x64; yarn package:arm64",
75
"hooks": {
86
"before:bump": "yarn declarations; yarn build:schemas",
9-
"after:bump": "yarn package:x64; yarn package:arm64",
10-
"after:release": "export VERSION=${version}; echo 'VERSION=${version}' >> $GITHUB_ENV"
7+
"after:release": "gh workflow run .github/workflows/release.yml version=${version}",
8+
"_": "CI will remove the _ from both of the below lines",
9+
"_after:bump": "yarn package:x64; yarn package:arm64",
10+
"_after:release": "export VERSION=${version}; echo 'VERSION=${version}' >> $GITHUB_ENV"
1111
}
1212
}

‎CHANGELOG.md

+7-2
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,16 @@
1616

1717
<!-- Your comment below this -->
1818

19-
- Support arm64 binary generation for Apple silicon users [#1342](https://github.com/danger/danger-js/pull/1342) [@pepix]
2019

2120
<!-- Your comment above this -->
2221

23-
## 11.1.2
22+
23+
## 11.2.1
24+
25+
- Updates jsonwebtoken due to security issues
26+
- Support arm64 binary generation for Apple silicon users [#1342](https://github.com/danger/danger-js/pull/1342) [@pepix]
27+
28+
## 11.2.1
2429

2530
- Bug fix for bitbucket bot detection ignoring case #1291
2631

‎README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,9 @@ Check the issues, I try and keep my short term perspective there. Long term is i
9999
Following [this commit](https://github.com/danger/danger-js/commit/a26ac3b3bd4f002acd37f6a363c8e74c9d5039ab) as a model:
100100

101101
- Checkout the `main` branch. Ensure your working tree is clean, and make sure you have the latest changes by running
102-
`git pull`.
102+
`git pull; yarn`.
103103
- Publish - `npm run release -- patch --ci`.
104+
- This will trigger a CI run which updates homebrew for the native builds
104105

105106
:ship:
106107

‎VISION.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ JS has been accomplished:
2626

2727
So, what now? Well. It's kinda done and now can mature. For the past few years Danger Ruby has solidified and become
2828
foundational infrastructure which you can trust won't change much, now Danger JS can be in the same place. This is a
29-
great place to be a developer tool.
29+
great place to be for a developer tool.
3030

3131
# Why Danger JS? What about Danger Ruby?
3232

0 commit comments

Comments
 (0)
Please sign in to comment.