Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: conventional-changelog/commitlint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3fce33999e1e5f23b15545f1c6f3e7bd78e8d37b
Choose a base ref
...
head repository: conventional-changelog/commitlint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 71f0194f33943954a8dac1c458be47e5049717cd
Choose a head ref

Commits on Jan 15, 2020

  1. Copy the full SHA
    b131a18 View commit details
  2. Copy the full SHA
    5d6bf9a View commit details
  3. docs: use latest node in travis guide (#871)

    The original Travis config does not use high enough version of node so the commitlint does not work. Updated docs accordingly
    vojtechruz authored and byCedric committed Jan 15, 2020
    Copy the full SHA
    02b5899 View commit details
  4. Copy the full SHA
    aabc549 View commit details
  5. Copy the full SHA
    09e9cde View commit details
  6. v8.3.5

    byCedric committed Jan 15, 2020
    Copy the full SHA
    b39e1ad View commit details

Commits on Jan 26, 2020

  1. refactor: upgrade babel from 6 to 7 (#886)

    * feat: upgrade babel from 6 to 7
    
    corejs@2 is deprecated
    
    * fix: add promise.finally
    
    * fix: rollback mistaken execa upgrade
    
    * chore: update rule names (import)
    
    * test: remove unnecessary arrow function
    
    * chore: remove unnecessary `/index`
    
    * chore: remove some leftovers from merge conflict
    
    * test: drop unnecessary notThrowsAsync
    
    * Revert "test: drop unnecessary notThrowsAsync"
    
    This reverts commit eba4002.
    
    * fix: drop some trash files after merge
    armano2 authored and byCedric committed Jan 26, 2020
    Copy the full SHA
    2549f79 View commit details
  2. Copy the full SHA
    b111e8f View commit details
  3. test: run jest in band on circle ci (#905)

    This prevents ts-jest to flood the memory, making it horrible slow and often failing without memory
    byCedric authored Jan 26, 2020
    Copy the full SHA
    10556ec View commit details
  4. refactor(rules): port rules to typescript (#785)

    * refactor(ensure): expose target case type for rules
    
    * refactor(rules): rewrite all rules and tests to typescript
    
    * refactor(rules): refactor indentation and readability for case rules
    
    * test(rules): ignore types file and use ts extension
    
    * test(rules): import non-typed preset with require
    
    * chore: remove javascript rules pattern from jest
    
    * fix(rules): export rule types for implementing packages
    byCedric authored Jan 26, 2020
    Copy the full SHA
    4cd2208 View commit details
  5. test(rules): migrate read tests from ava to jest (#904)

    Co-authored-by: Cedric van Putten <me@bycedric.com>
    armano2 and byCedric committed Jan 26, 2020
    Copy the full SHA
    b01152d View commit details
  6. refactor(test): port test utils to typescript (#906)

    * chore: refactor test utils to typescript
    
    * test: fix new unit test after rebase
    
    * chore: apply changes from review
    
    * chore: restore launch.json
    armano2 authored and byCedric committed Jan 26, 2020
    Copy the full SHA
    bc548de View commit details
  7. test(cli): migrates tests from ava to jest (#907)

    * test(cli): migrates tests from ava to jest
    
    * test: fix stdout -> stderr
    
    * test(cli): update comments
    
    * chore: change main to index.js and update types
    armano2 authored and byCedric committed Jan 26, 2020
    Copy the full SHA
    afb2105 View commit details
  8. Copy the full SHA
    b512ac7 View commit details

Commits on Jan 27, 2020

  1. Copy the full SHA
    ddb5670 View commit details
  2. Copy the full SHA
    4889cee View commit details
  3. test(travis-cli): migrate tests from ava to jest (#910)

    * test(travis-cli): migrate tests from ava to jest
    
    * test(travis-cli): remove redundant tests
    
    * test(travis-cli): fix and enable mocked tests
    
    * test(travis-cli): restore some original code
    
    Co-authored-by: Cedric van Putten <me@bycedric.com>
    armano2 and byCedric committed Jan 27, 2020
    Copy the full SHA
    f3af938 View commit details

Commits on Jan 28, 2020

  1. Copy the full SHA
    fac8171 View commit details

Commits on Feb 3, 2020

  1. Copy the full SHA
    ee5eac9 View commit details
  2. Copy the full SHA
    ff11998 View commit details
  3. Copy the full SHA
    a474224 View commit details
  4. refactor: port load to typescript (#786)

    * refactor: port load to typescript [wip]
    
    * refactor: port load to typescript [wip]
    
    * refactor(load): finish port to typescript
    
    * fix(cli): unpack load from default when importing
    
    * refactor(load): beef up typings
    
    * fix(load): repair botched merge
    
    * test: port load tests from ava to jest
    
    Co-authored-by: Armano <armano2@users.noreply.github.com>
    
    * fix: propagate tightened types
    
    * refactor: move out helper functions
    
    * test: match prompt-cli tests correctly
    
    * fix: add missing dependency on @commitlint/rules
    
    * fix: add missing reference
    
    * fix: add missing references
    
    Co-authored-by: Mario Nebl <marionebl@users.noreply.github.com>
    Co-authored-by: Armano <armano2@users.noreply.github.com>
    3 people authored Feb 3, 2020
    Copy the full SHA
    ac71331 View commit details
  5. refactor: port read to ts (#922)

    * refactor: port read to typescript
    
    * fix: use @types/git-raw-commits
    
    * fix: adapt to latest master
    
    * refactor: unnest getEditFilePath
    
    * style: apply autoformatting
    marionebl authored Feb 3, 2020
    Copy the full SHA
    f0dd45d View commit details
  6. Copy the full SHA
    ece5efd View commit details
  7. Copy the full SHA
    039eb60 View commit details
  8. chore: update dependency @types/node to v12.12.26 (#841)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    1bab4dd View commit details
  9. chore: update dependency @types/jest to v24.9.1 (#842)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    d2f641a View commit details
  10. chore: update dependency @types/jest to v25 (#926)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    5ddc35c View commit details
  11. chore: update dependency cosmiconfig to v6 (#845)

    * chore: update dependency cosmiconfig to v6
    
    * fix: adapt to cosmiconfig@6 changes
    
    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    Co-authored-by: Mario Nebl <marionebl@users.noreply.github.com>
    3 people authored Feb 3, 2020
    Copy the full SHA
    cf31293 View commit details
  12. chore: update dependency typescript to v3.7.5 (#849)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    3e30112 View commit details
  13. chore: update dependency @types/lodash to v4.14.149 (#850)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    d74b40b View commit details
  14. chore: update dependency lerna to v3.20.2 (#851)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    8502124 View commit details
  15. chore: update dependency conventional-changelog-conventionalcommits t…

    …o v4.2.3 (#854)
    
    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    fb9f851 View commit details
  16. chore: update dependency conventional-changelog-angular to v5.0.6 (#855)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    3476234 View commit details
  17. Copy the full SHA
    056c6fe View commit details
  18. chore: update dependency semver to v7 (#877)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 3, 2020
    Copy the full SHA
    2bc32da View commit details

Commits on Feb 4, 2020

  1. chore: update dependency jest to v25 (#929)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    a26f83c View commit details
  2. chore: update dependency ts-jest to v25 (#931)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    Co-authored-by: Mario Nebl <marionebl@users.noreply.github.com>
    3 people authored Feb 4, 2020
    Copy the full SHA
    f9960b6 View commit details
  3. chore: update dependency chalk to v3 (#853)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    bdd3bb3 View commit details
  4. chore: update dependency globby to v10.0.2 (#892)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    f3ab989 View commit details
  5. chore: use frozen lockfile to fail build if an update is needed (#920)

    * test: add ci step to verify if lockfile is valid
    
    * chore: remove git diff
    armano2 authored Feb 4, 2020
    Copy the full SHA
    5c0f1c0 View commit details
  6. chore: update dependency husky to v4 (#894)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    10c250e View commit details
  7. fix: #840 add caret to lodash versions (#843)

    Co-authored-by: Mario Nebl <marionebl@users.noreply.github.com>
    lgraziani2712 and marionebl authored Feb 4, 2020
    Copy the full SHA
    ffc0bac View commit details
  8. Copy the full SHA
    a7008ff View commit details
  9. test(config-lerna-scopes): migrate ava tests to jest (#914)

    * test(config-lerna-scopes): migrate ava tests to jest
    
    * test(config-lerna-scopes): fix timeout
    
    * test: remove ava from dependencies
    
    * test(config-lerna-scopes): increase timeout to 60sec
    armano2 authored Feb 4, 2020
    Copy the full SHA
    35e1707 View commit details
  10. chore: update dependency cross-env to v7 (#928)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    a1fdb76 View commit details
  11. chore: update dependency globby to v11 (#893)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    eaf6ba2 View commit details
  12. chore: update dependency lint-staged to v10 (#930)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    3956489 View commit details
  13. chore: update dependency lerna to ^3.20.2 (#936)

    Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
    renovate[bot] and renovate-bot authored Feb 4, 2020
    Copy the full SHA
    6b86efe View commit details
  14. Copy the full SHA
    a296d81 View commit details
Showing 332 changed files with 11,070 additions and 11,338 deletions.
37 changes: 31 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
version: 2.1

orbs:
win: circleci/windows@2.4.0

commands:
update-yarn:
steps:
@@ -10,7 +13,7 @@ commands:
steps:
- run:
name: Install dependencies
command: yarn install --ignore-engines
command: yarn install --ignore-engines --frozen-lockfile
audit:
steps:
- run:
@@ -26,6 +29,11 @@ commands:
- run:
name: Lint project
command: yarn lint
format:
steps:
- run:
name: Format project
command: yarn format
deps:
steps:
- run:
@@ -35,14 +43,14 @@ commands:
steps:
- run:
name: Test
command: yarn test
command: yarn test-ci
save-cache:
steps:
- save_cache:
key: v{{ .Environment.CIRCLE_CACHE_VERSION }}-{{ arch }}-npm-lock-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
paths:
- node_modules
run-node:
run-all:
steps:
- checkout
- restore_cache:
@@ -53,28 +61,45 @@ commands:
- save-cache
- build
- lint
- format
- deps
- test
run-tests:
steps:
- checkout
- restore_cache:
keys:
- v1-dependencies-{{ checksum "yarn.lock" }}
- update-yarn
- install
- save-cache
- build
- test
jobs:
v8:
docker:
- image: node:8
steps:
- run-node
- run-tests
v10:
docker:
- image: node:10
steps:
- run-node
- run-tests
v12:
docker:
- image: node:12
steps:
- run-node
- run-all
windows-v12:
executor: win/default
steps:
- run-tests

workflows:
node:
jobs:
- v8
- v10
- v12
- windows-v12
22 changes: 11 additions & 11 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "commitlint-dev",
"dockerComposeFile": ["../docker-compose.yml"],
"service": "commitlint",
"workspaceFolder": "/root/repo",
"shutdownAction": "stopCompose",
"extensions": [
"editorconfig.editorconfig",
"ms-vsliveshare.vsliveshare-pack",
"ms-azuretools.vscode-docker",
"esbenp.prettier-vscode"
]
"name": "commitlint-dev",
"dockerComposeFile": ["../docker-compose.yml"],
"service": "commitlint",
"workspaceFolder": "/root/repo",
"shutdownAction": "stopCompose",
"extensions": [
"editorconfig.editorconfig",
"ms-vsliveshare.vsliveshare-pack",
"ms-azuretools.vscode-docker",
"esbenp.prettier-vscode"
]
}
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ insert_final_newline = true
trim_trailing_whitespace = true
indent_style = tab

[{.*rc,*.yml,*.md,package.json,lerna.json,*.svg}]
[{.*rc,*.yml,*.md,*.json,*.svg}]
indent_style = space

[*.md]
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
lib/
coverage/
node_modules/
fixtures/
74 changes: 74 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
module.exports = {
root: true,
plugins: ['@typescript-eslint', 'jest', 'import'],
env: {
es6: true,
node: true
},
parserOptions: {
sourceType: 'module',
ecmaVersion: 11,
ecmaFeatures: {
jsx: false
}
},
extends: ['eslint:recommended', 'prettier'],
rules: {
// disallow non-import statements appearing before import statements
'import/first': 'error',
// Forbid import of modules using absolute paths
'import/no-absolute-path': 'error',
// disallow AMD require/define
'import/no-amd': 'error',
// Forbid mutable exports
'import/no-mutable-exports': 'error',
// Prevent importing the default as if it were named
'import/no-named-default': 'error',
// Forbid a module from importing itself
'import/no-self-import': 'error'

// Enable after https://github.com/benmosher/eslint-plugin-import/issues/1650 is fixed
// Forbid the use of extraneous packages
// 'import/no-extraneous-dependencies': [
// 'error',
// {devDependencies: ['**/*.test.js']}
// ]
},
overrides: [
{
files: ['*.ts'],
parser: '@typescript-eslint/parser',
extends: [
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'prettier/@typescript-eslint'
],
rules: {
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',

// TODO: enable those rules?
'no-empty': 'off',
'no-var': 'off'
}
},
{
files: ['*.test.ts', '*.test.js'],
env: {
jest: true
},
extends: ['plugin:jest/recommended'],
rules: {
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-var-requires': 'off',
// disallow non-import statements appearing before import statements
'import/first': 'off'
}
}
]
};
20 changes: 10 additions & 10 deletions .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -8,19 +8,19 @@ In the interest of fostering an open and welcoming environment, we as contributo

Examples of behavior that contributes to creating a positive environment include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

53 changes: 29 additions & 24 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -6,52 +6,57 @@ Yeay! You want to contribute to commitlint. That's amazing!
To smoothen everyone's experience involved with the project please take note of the following guidelines and rules.

## Found an Issue?

Thank you for reporting any issues you find. We do our best to test and make commitlint as solid as possible, but any reported issue is a real help.

> commitlint issues
Please follow these guidelines when reporting issues:
* Provide a title in the format of `<Error> when <Task>`
* Tag your issue with the tag `bug`
* Provide a short summary of what you are trying to do
* Provide the log of the encountered error if applicable
* Provide the exact version of commitlint. Check `npm ls @commitlint/cli` when in doubt
* Be awesome and consider contributing a [pull request](#want-to-contribute)

- Provide a title in the format of `<Error> when <Task>`
- Tag your issue with the tag `bug`
- Provide a short summary of what you are trying to do
- Provide the log of the encountered error if applicable
- Provide the exact version of commitlint. Check `npm ls @commitlint/cli` when in doubt
- Be awesome and consider contributing a [pull request](#want-to-contribute)

## Want to contribute?

You consider contributing changes to commitlint – we dig that!
Please consider these guidelines when filing a pull request:

> commitlint pull requests
* Follow the [Coding Rules](#coding-rules)
* Follow the [Commit Rules](#commit-rules)
* Make sure you rebased the current master branch when filing the pull request
* Squash your commits when filing the pull request
* Provide a short title with a maximum of 100 characters
* Provide a more detailed description containing
* What you want to achieve
* What you changed
* What you added
* What you removed
- Follow the [Coding Rules](#coding-rules)
- Follow the [Commit Rules](#commit-rules)
- Make sure you rebased the current master branch when filing the pull request
- Squash your commits when filing the pull request
- Provide a short title with a maximum of 100 characters
- Provide a more detailed description containing
_ What you want to achieve
_ What you changed
_ What you added
_ What you removed

## Coding Rules

To keep the code base of commitlint neat and tidy the following rules apply to every change

> Coding standards
* `prettier` is king
* Favor micro library over swiss army knives (rimraf, ncp vs. fs-extra)
* Be awesome
- `prettier` is king
- Favor micro library over swiss army knives (rimraf, ncp vs. fs-extra)
- Be awesome

## Commit Rules

To help everyone with understanding the commit history of commitlint the following commit rules are enforced.
To make your life easier commitlint is commitizen-friendly and provides the npm run-script `commit`.

> Commit standards
* [conventional-changelog](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/prompt)
* husky commit message hook available
* present tense
* maximum of 100 characters
* message format of `$type($scope): $message`
- [conventional-changelog](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/prompt)
- husky commit message hook available
- present tense
- maximum of 100 characters
- message format of `$type($scope): $message`
30 changes: 18 additions & 12 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,34 @@
<!--- Provide a general summary of the issue in the Title above -->

## Expected Behavior

<!--- If you're describing a bug, tell us what should happen -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->

## Current Behavior

<!--- If describing a bug, tell us what happens instead of the expected behavior -->
<!--- If suggesting a change/improvement, explain the difference from current behavior -->

## Affected packages
* [ ] cli
* [ ] core
* [ ] prompt
* [ ] config-angular

- [ ] cli
- [ ] core
- [ ] prompt
- [ ] config-angular

## Possible Solution

<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->

## Steps to Reproduce (for bugs)

<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.

1. First step
2. Second step

<details>
<summary>commitlint.config.js</summary>
@@ -35,14 +39,16 @@
</details>

## Context

<!--- How has this issue affected you? What are you trying to accomplish? -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->

## Your Environment

<!--- Include as many relevant details about the environment you experienced the bug in -->

| Executable | Version |
| ---: | :--- |
| Executable | Version |
| ---------------------: | :------ |
| `commitlint --version` | VERSION |
| `git --version` | VERSION |
| `node --version` | VERSION |
| `git --version` | VERSION |
| `node --version` | VERSION |
Loading