C3: Remove polling for deployment url at end of workflow (#3233)

Author: jculvey

package-lock.json

@@ -40,7 +40,6 @@
 		"execa": "^7.1.1",
 		"haikunator": "^2.1.2",
 		"log-update": "^5.0.1",
-		"open": "^8.4.0",
 		"recast": "^0.22.0",
 		"typescript": "^5.0.2",
 		"undici": "^5.22.0",

packages/create-cloudflare/package.json

@@ -38,12 +38,6 @@ const parseArgs = async (argv: string[]) => {
 		.option("framework", { type: "string" })
 		.option("deploy", { type: "boolean" })
 		.option("ts", { type: "boolean" })
-		.option("open", {
-			type: "boolean",
-			default: true,
-			description:
-				"opens your browser after your deployment, set --no-open to disable",
-		})
 		.help().argv;
 
 	const [name] = args._;

packages/create-cloudflare/src/cli.ts

@@ -7,7 +7,6 @@ import {
 	log,
 	logRaw,
 	newline,
-	openInBrowser,
 	shapes,
 	startSection,
 } from "helpers/cli";
@@ -18,8 +17,7 @@ import {
 	runCommand,
 	wranglerLogin,
 } from "helpers/command";
-import { confirmInput, selectInput, spinner } from "helpers/interactive";
-import { poll } from "helpers/poll";
+import { confirmInput, selectInput } from "helpers/interactive";
 import type { Option } from "helpers/interactive";
 import type { PagesGeneratorArgs, PagesGeneratorContext } from "types";
 
@@ -161,6 +159,7 @@ export const printSummary = async (ctx: PagesGeneratorContext) => {
 			`${bgGreen(" SUCCESS ")}`,
 			`${dim(`View your deployed application at`)}`,
 			`${blue(ctx.deployedUrl)}`,
+			`${dim(`(this may take a few mins)`)}`,
 		].join(" ");
 		logRaw(msg);
 	} else {
@@ -181,28 +180,5 @@ export const printSummary = async (ctx: PagesGeneratorContext) => {
 	});
 	newline();
 
-	if (ctx.deployedUrl) {
-		const s = spinner();
-		s.start("Waiting for deployment to become available");
-
-		const success = await poll(ctx.deployedUrl);
-
-		if (success) {
-			s.stop(
-				`${brandColor("deployment")} ${dim("is ready at:")} ${blue(
-					ctx.deployedUrl
-				)}`
-			);
-
-			if (ctx.args.open) {
-				await openInBrowser(ctx.deployedUrl);
-			}
-		} else {
-			s.stop(
-				`${brandColor("deployment")} timed out waiting for ${ctx.deployedUrl}.`
-			);
-		}
-	}
-
 	endSection("See you again soon!");
 };

packages/create-cloudflare/src/common.ts

@@ -1,5 +1,4 @@
 import { exit } from "process";
-import open from "open";
 import { brandColor, dim, gray, white, red, hidden, bgRed } from "./colors";
 
 export const shapes = {
@@ -112,19 +111,3 @@ export const crash = (msg?: string): never => {
 	}
 	exit(1);
 };
-
-/**
- * An extremely simple wrapper around the open command.
- * Specifically, it adds an 'error' event handler so that when this function
- * is called in environments where we can't open the browser (e.g. GitHub Codespaces,
- * StackBlitz, remote servers), it doesn't just crash the process.
- *
- * @param url the URL to point the browser at
- */
-export async function openInBrowser(url: string): Promise<void> {
-	updateStatus("Opening browser");
-	const childProcess = await open(url);
-	childProcess.on("error", () => {
-		warn("Failed to open browser");
-	});
-}

packages/create-cloudflare/src/helpers/cli.ts

@@ -9,7 +9,6 @@ export type PagesGeneratorArgs = {
 	frameworkChoices?: FrameworkName[];
 	deploy?: boolean;
 	ts?: boolean;
-	open: boolean;
 };
 
 export type PagesGeneratorContext = {