Catch errors when logging requests

If Miniflare is disposed before `workerd` finishes sending a request
log, incomplete JSON-data may be sent, which will cause an error.
This change catches errors when parsing request logs since it's not
too important if these aren't logged.

Author: mrbbot

packages/miniflare/src/index.ts

@@ -65,6 +65,7 @@ import {
   Mutex,
   NoOpLog,
   OptionalZodTypeOf,
+  ResponseInfoSchema,
   Timers,
   defaultTimers,
   formatResponse,
@@ -580,7 +581,16 @@ export class Miniflare {
           request
         );
       } else if (url.pathname === "/core/log") {
-        this.#log.info(await formatResponse(request));
+        const text = await request.text();
+        try {
+          // `JSON.parse()`ing may fail if the request was aborted and a partial
+          // body was received
+          const info = ResponseInfoSchema.parse(JSON.parse(text));
+          this.#log.info(await formatResponse(info));
+        } catch (e: unknown) {
+          this.#log.debug(`Error parsing response log: ${String(e)}`);
+        }
+        response = new Response(null, { status: 204 });
       } else {
         // TODO: check for proxying/outbound fetch header first (with plans for fetch mocking)
         response = await this.#handleLoopbackPlugins(request, url);

packages/miniflare/src/shared/log.ts

@@ -11,7 +11,6 @@ import {
   yellow,
 } from "kleur/colors";
 import { z } from "zod";
-import { Request } from "../http";
 import { LogLevel } from "../workers";
 
 const cwd = process.cwd();
@@ -130,16 +129,16 @@ export class NoOpLog extends Log {
   }
 }
 
-const ResponseInfoSchema = z.object({
+export const ResponseInfoSchema = z.object({
   status: z.number(),
   statusText: z.string(),
   method: z.string(),
   url: z.string(),
   time: z.number(),
 });
+export type ResponseInfo = z.infer<typeof ResponseInfoSchema>;
 
-export async function formatResponse(request: Request) {
-  const info = ResponseInfoSchema.parse(await request.json());
+export async function formatResponse(info: ResponseInfo) {
   const url = new URL(info.url);
 
   const lines = [