Timepicker hour 12 displayed as 0

[cain]

Overview of the problem

Buefy version: Latest
Vuejs version: -
OS/Browser: -

Description

Timepicker component hour selector shows "12". But once selected the hour displayed is "0".

Looking into it, seems like 0 PM or 0 AM is correct. But maybe we want to support a way to display as 12 PM?

Steps to reproduce

1. Use timepicker component
2. Use 12 hour formate
3. Select hour 12
4. See value displayed

Expected behavior

Display hour value as "12"

Actual behavior

Hour value displaying as "0" for both PM and AM values

Example on docs: https://buefy.org/documentation/timepicker

[jtommy]

@cain I investigated about and it's relative to Intl.DateTimeFormat because internally the component use it (you can override it anyway).
An official bug of Intl.DateTimeFormat ?

[cain]

@jtommy thanks for looking, i also had a look and it turns out 0 is the "correct" display. Thanks ill use the override :)

[cain]

@jtommy Buefy uses the hour12 option which converts 12 pm to 0 pm.

Changing this to use hourCycle: 'h12' worked instead of hour12: true

Do you think the default Buefy format function needs to be updated to use this param instead?

See https://stackoverflow.com/questions/63273543/javascript-intl-datetimeformat-hours12-gives-odd-output-on-chrome

CleanShot.2021-10-27.at.09.37.27.mp4

[jtommy]

@cain yes, please make a PR

[jezmck]

This is likely because of https://bugs.chromium.org/p/chromium/issues/detail?id=1347316