Skip to content

Commit 9e6f936

Browse files
committedSep 28, 2023
[Tests] avoid publishing "malformed package.json" test to avoid flawed security scanners
Fixes #319. Fixes #318. Fixes #317. Fixes #314. Closes #313. Fixes #312. Fixes #311. Fixes #310. Fixes #309. Fixes #306. Fixes #305. Fixes #304. Fixes #303. Fixes #291. Fixes #288.
1 parent 2ae67c1 commit 9e6f936

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed
 

‎package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@
6565
"publishConfig": {
6666
"ignore": [
6767
".github/workflows",
68-
"appveyor.yml"
68+
"appveyor.yml",
69+
"test/resolver/malformed_package_json"
6970
]
7071
}
7172
}

‎test/resolver.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
var path = require('path');
2+
var fs = require('fs');
23
var test = require('tape');
34
var resolve = require('../');
45
var async = require('../async');
@@ -539,14 +540,15 @@ test('absolute paths', function (t) {
539540
});
540541
});
541542

542-
test('malformed package.json', function (t) {
543+
var malformedDir = path.join(__dirname, 'resolver/malformed_package_json');
544+
test('malformed package.json', { skip: !fs.existsSync(malformedDir) }, function (t) {
543545
/* eslint operator-linebreak: ["error", "before"], function-paren-newline: "off" */
544546
t.plan(
545547
(3 * 3) // 3 sets of 3 assertions in the final callback
546548
+ 2 // 1 readPackage call with malformed package.json
547549
);
548550

549-
var basedir = path.join(__dirname, 'resolver/malformed_package_json');
551+
var basedir = malformedDir;
550552
var expected = path.join(basedir, 'index.js');
551553

552554
resolve('./index.js', { basedir: basedir }, function (err, res, pkg) {

‎test/resolver_sync.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -667,10 +667,11 @@ test('absolute paths', function (t) {
667667
t.end();
668668
});
669669

670-
test('malformed package.json', function (t) {
670+
var malformedDir = path.join(__dirname, 'resolver/malformed_package_json');
671+
test('malformed package.json', { skip: !fs.existsSync(malformedDir) }, function (t) {
671672
t.plan(5 + (requireResolveSupportsPaths ? 1 : 0));
672673

673-
var basedir = path.join(__dirname, 'resolver/malformed_package_json');
674+
var basedir = malformedDir;
674675
var expected = path.join(basedir, 'index.js');
675676

676677
t.equal(

0 commit comments

Comments
 (0)
Please sign in to comment.