Cli tests (#252)

* chore: downgrade to mocha@7 for node 8 testing

* chore: CLI test

* chore: eslint

* chore: switch to github actions for CI

Author: broofa

.eslintrc.json

@@ -9,6 +9,7 @@
     "node": true,
     "mocha": true
   },
+  "ignorePatterns": ["types/"],
   "extends": ["eslint:recommended"],
   "rules": {
     "array-bracket-spacing": ["warn", "never"],
@@ -37,6 +38,7 @@
     "no-undef": "error",
     "no-unused-vars": ["warn", {"args": "none"}],
     "one-var": ["warn", "never"],
+    "no-var": "warn",
     "padded-blocks": ["warn", "never"],
     "object-curly-spacing": ["warn", "never"],
     "quotes": ["warn", "single"],

.github/workflows/ci.yml

@@ -1,10 +1,7 @@
-name: Node.js CI
+name: Mime CI
 
 on:
-  push:
-    branches: [ $default-branch ]
-  pull_request:
-    branches: [ $default-branch ]
+  [push]
 
 jobs:
   build:

Mime.js

@@ -8,7 +8,7 @@ function Mime() {
   this._types = Object.create(null);
   this._extensions = Object.create(null);
 
-  for (var i = 0; i < arguments.length; i++) {
+  for (let i = 0; i < arguments.length; i++) {
     this.define(arguments[i]);
   }
 
@@ -37,16 +37,18 @@ function Mime() {
  * @param force (Boolean) if true, force overriding of existing definitions
  */
 Mime.prototype.define = function(typeMap, force) {
-  for (var type in typeMap) {
-    var extensions = typeMap[type].map(function(t) {return t.toLowerCase()});
+  for (let type in typeMap) {
+    let extensions = typeMap[type].map(function(t) {
+      return t.toLowerCase();
+    });
     type = type.toLowerCase();
 
-    for (var i = 0; i < extensions.length; i++) {
-      var ext = extensions[i];
+    for (let i = 0; i < extensions.length; i++) {
+      const ext = extensions[i];
 
       // '*' prefix = not the preferred type for this extension.  So fixup the
       // extension, and skip it.
-      if (ext[0] == '*') {
+      if (ext[0] === '*') {
         continue;
       }
 
@@ -64,8 +66,8 @@ Mime.prototype.define = function(typeMap, force) {
 
     // Use first extension as default
     if (force || !this._extensions[type]) {
-      var ext = extensions[0];
-      this._extensions[type] = (ext[0] != '*') ? ext : ext.substr(1)
+      const ext = extensions[0];
+      this._extensions[type] = (ext[0] !== '*') ? ext : ext.substr(1);
     }
   }
 };
@@ -75,11 +77,11 @@ Mime.prototype.define = function(typeMap, force) {
  */
 Mime.prototype.getType = function(path) {
   path = String(path);
-  var last = path.replace(/^.*[/\\]/, '').toLowerCase();
-  var ext = last.replace(/^.*\./, '').toLowerCase();
+  let last = path.replace(/^.*[/\\]/, '').toLowerCase();
+  let ext = last.replace(/^.*\./, '').toLowerCase();
 
-  var hasPath = last.length < path.length;
-  var hasDot = ext.length < last.length - 1;
+  let hasPath = last.length < path.length;
+  let hasDot = ext.length < last.length - 1;
 
   return (hasDot || !hasPath) && this._types[ext] || null;
 };

cli.js

@@ -3,19 +3,17 @@
 'use strict';
 
 process.title = 'mime';
-var mime = require('.');
-var pkg = require('./package.json');
-var args = process.argv.splice(2);
+let mime = require('.');
+let pkg = require('./package.json');
+let args = process.argv.splice(2);
 
 if (args.includes('--version') || args.includes('-v') || args.includes('--v')) {
   console.log(pkg.version);
   process.exit(0);
-}
-else if (args.includes('--name') || args.includes('-n') || args.includes('--n')) {
+} else if (args.includes('--name') || args.includes('-n') || args.includes('--n')) {
   console.log(pkg.name);
   process.exit(0);
-}
-else if (args.includes('--help') || args.includes('-h') || args.includes('--h')) {
+} else if (args.includes('--help') || args.includes('-h') || args.includes('--h')) {
   console.log(pkg.name + ' - ' + pkg.description + '\n');
   console.log(`Usage:
 
@@ -41,8 +39,8 @@ else if (args.includes('--help') || args.includes('-h') || args.includes('--h'))
   process.exit(0);
 }
 
-var file = args[0];
-var type = mime.getType(file);
+let file = args[0];
+let type = mime.getType(file);
 
 process.stdout.write(type + '\n');
 

index.js

@@ -1,4 +1,4 @@
 'use strict';
 
-var Mime = require('./Mime');
+let Mime = require('./Mime');
 module.exports = new Mime(require('./types/standard'), require('./types/other'));

lite.js

@@ -1,4 +1,4 @@
 'use strict';
 
-var Mime = require('./Mime');
+let Mime = require('./Mime');
 module.exports = new Mime(require('./types/standard'));

mime.code-workspace

@@ -0,0 +1,7 @@
+{
+  "folders": [
+    {
+      "path": "."
+    }
+  ]
+}

package-lock.json

@@ -21,7 +21,7 @@
     "mime-db": "1.45.0",
     "mime-score": "1.2.0",
     "mime-types": "2.1.27",
-    "mocha": "8.2.1",
+    "mocha": "7.2.0",
     "runmd": "*",
     "standard-version": "9.0.0"
   },

package.json

@@ -1,3 +1,5 @@
+'use strict';
+
 const Benchmark = require('benchmark');
 const mime = require('..');
 const mimeLite = require('../lite');

src/benchmark.js

@@ -2,29 +2,29 @@
 
 'use strict';
 
-var fs = require('fs');
-var path = require('path');
-var mimeScore = require('mime-score');
+let fs = require('fs');
+let path = require('path');
+let mimeScore = require('mime-score');
 
-var db = require('mime-db');
-var chalk = require('chalk');
+let db = require('mime-db');
+let chalk = require('chalk');
 
-var STANDARD_FACET_SCORE = 900;
+let STANDARD_FACET_SCORE = 900;
 
-var byExtension = {};
+let byExtension = {};
 
 // Clear out any conflict extensions in mime-db
-for (var type in db) {
-  var entry = db[type];
+for (let type in db) {
+  const entry = db[type];
   entry.type = type;
   if (!entry.extensions) continue;
 
   entry.extensions.forEach(function(ext) {
-    var drop;
-    var keep = entry;
+    let drop;
+    let keep = entry;
     if (ext in byExtension) {
-      var e0 = entry;
-      var e1 = byExtension[ext];
+      let e0 = entry;
+      let e1 = byExtension[ext];
 
       e0.pri = mimeScore(e0.type, e0.source);
       e1.pri = mimeScore(e1.type, e1.source);
@@ -33,7 +33,9 @@ for (var type in db) {
       keep = e0.pri >= e1.pri ? e0 : e1;
 
       // Prefix lower-priority extensions with '*'
-      drop.extensions = drop.extensions.map(function(e) {return e == ext ? '*' + e : e});
+      drop.extensions = drop.extensions.map(function(e) {
+        return e === ext ? '*' + e : e;
+      });
 
       console.log(
         ext + ': Preferring ' + chalk.green(keep.type) + ' (' + keep.pri +
@@ -42,7 +44,7 @@ for (var type in db) {
     }
 
     // Cache the hightest ranking type for this extension
-    if (keep == entry) byExtension[ext] = entry;
+    if (keep === entry) byExtension[ext] = entry;
   });
 }
 
@@ -52,11 +54,11 @@ function writeTypesFile(types, path) {
 
 // Segregate into standard and non-standard types based on facet per
 // https://tools.ietf.org/html/rfc6838#section-3.1
-var standard = {};
-var other = {};
+let standard = {};
+let other = {};
 
 Object.keys(db).sort().forEach(function(k) {
-  var entry = db[k];
+  let entry = db[k];
 
   if (entry.extensions) {
     if (mimeScore(entry.type, entry.source) >= STANDARD_FACET_SCORE) {

src/build.js

@@ -1,9 +1,10 @@
 'use strict';
 
-var mime = require('..');
-var mimeTypes = require('../node_modules/mime-types');
-var assert = require('assert');
-var chalk = require('chalk');
+const mime = require('..');
+const mimeTypes = require('../node_modules/mime-types');
+const assert = require('assert');
+const chalk = require('chalk');
+const {exec} = require('child_process');
 
 describe('class Mime', function() {
   it('mime and mime/lite coexist', function() {
@@ -13,9 +14,9 @@ describe('class Mime', function() {
   });
 
   it('new constructor()', function() {
-    var Mime = require('../Mime');
+    let Mime = require('../Mime');
 
-    var mime = new Mime(
+    let mime = new Mime(
       {'text/a': ['a', 'a1']},
       {'text/b': ['b', 'b1']}
     );
@@ -34,9 +35,9 @@ describe('class Mime', function() {
   });
 
   it('define()', function() {
-    var Mime = require('../Mime');
+    let Mime = require('../Mime');
 
-    var mime = new Mime({'text/a': ['a']}, {'text/b': ['b']});
+    let mime = new Mime({'text/a': ['a']}, {'text/b': ['b']});
 
     assert.throws(function() {
       mime.define({'text/c': ['b']});
@@ -59,9 +60,9 @@ describe('class Mime', function() {
   });
 
   it('define() *\'ed types', function() {
-    var Mime = require('../Mime');
+    let Mime = require('../Mime');
 
-    var mime = new Mime(
+    let mime = new Mime(
       {'text/a': ['*b']},
       {'text/b': ['b']}
     );
@@ -77,7 +78,7 @@ describe('class Mime', function() {
   });
 
   it ('case-insensitive', function() {
-    var Mime = require('../Mime');
+    let Mime = require('../Mime');
     const mime = new Mime({
       'TEXT/UPPER': ['UP'],
       'text/lower': ['low'],
@@ -146,7 +147,7 @@ describe('class Mime', function() {
 });
 
 describe('DB', function() {
-  var diffs = [];
+  let diffs = [];
 
   after(function() {
     if (diffs.length) {
@@ -161,14 +162,14 @@ describe('DB', function() {
   });
 
   it('Consistency', function() {
-    for (var ext in this.types) {
+    for (let ext in this.types) {
       assert.equal(ext, this.extensions[this.types[ext]], '${ext} does not have consistent ext->type->ext mapping');
     }
   });
 
   it('MDN types', function() {
     // MDN types listed at https://goo.gl/lHrFU6
-    var MDN = {
+    let MDN = {
       aac: 'audio/aac',
       abw: 'application/x-abiword',
       arc: 'application/x-freearc',
@@ -245,15 +246,15 @@ describe('DB', function() {
       '7z': 'application/x-7z-compressed',
     };
 
-    for (var ext in MDN) {
-      var expected = MDN[ext];
-      var actual = mime.getType(ext);
+    for (let ext in MDN) {
+      let expected = MDN[ext];
+      let actual = mime.getType(ext);
       if (actual !== expected) diffs.push(['MDN', ext, expected, actual]);
     }
 
-    for (var ext in mimeTypes.types) {
-      var expected = mimeTypes.types[ext];
-      var actual = mime.getType(ext);
+    for (let ext in mimeTypes.types) {
+      let expected = mimeTypes.types[ext];
+      let actual = mime.getType(ext);
       if (actual !== expected) diffs.push(['mime-types', ext, expected, actual]);
     }
   });
@@ -291,3 +292,14 @@ describe('DB', function() {
     assert.equal(mime.getExtension('text/xml'), 'xml'); // See #180
   });
 });
+
+describe('mime CLI', function() {
+  it('returns type', function(done) {
+    exec('./cli.js mpeg', (err, stdout, stderr) => {
+      if (err) done(err);
+      assert.equal(stdout, 'video/mpeg\n');
+      done();
+    });
+  });
+});
+