Fix most SSL negotiation packet tests being ignored

charmander · charmander · commit 3edcbb784fde · 2020-07-26T20:54:43.000-07:00
`tc` was only one variable and the tests are asynchronous, so every test was writing 'E'.
diff --git a/packages/pg/test/unit/connection/error-tests.js b/packages/pg/test/unit/connection/error-tests.js
@@ -58,8 +58,7 @@ var SSLNegotiationPacketTests = [
   },
 ]
 
-for (var i = 0; i < SSLNegotiationPacketTests.length; i++) {
-  var tc = SSLNegotiationPacketTests[i]
+for (const tc of SSLNegotiationPacketTests) {
   suite.test(tc.testName, function (done) {
     // our fake postgres server
     var socket

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,7 @@ var SSLNegotiationPacketTests = [`
`58`	`58`	`},`
`59`	`59`	`]`
`60`	`60`
`61`		`-for (var i = 0; i < SSLNegotiationPacketTests.length; i++) {`
`62`		`- var tc = SSLNegotiationPacketTests[i]`
	`61`	`+for (const tc of SSLNegotiationPacketTests) {`
`63`	`62`	`suite.test(tc.testName, function (done) {`
`64`	`63`	`// our fake postgres server`
`65`	`64`	`var socket`