Performance problem when pageBreakBefore for large files used fixed (v0.1) (#2203)

* pageBreakBefore performance fix

* array fix

* tests fix

* test fix

Author: psaawkel

src/layoutBuilder.js

@@ -81,11 +81,7 @@ LayoutBuilder.prototype.layoutDocument = function (docStructure, fontProvider, s
 				}
 			});
 			nodeInfo.startPosition = node.positions[0];
-			nodeInfo.pageNumbers = node.positions.map(function (node) {
-				return node.pageNumber;
-			}).filter(function (element, position, array) {
-				return array.indexOf(element) === position;
-			});
+			nodeInfo.pageNumbers = Array.from(new Set(node.positions.map(function (node) {return node.pageNumber;})));
 			nodeInfo.pages = pages.length;
 			nodeInfo.stack = isArray(node.stack);
 
@@ -100,17 +96,21 @@ LayoutBuilder.prototype.layoutDocument = function (docStructure, fontProvider, s
 				var followingNodesOnPage = [];
 				var nodesOnNextPage = [];
 				var previousNodesOnPage = [];
-				for (var ii = index + 1, l = linearNodeList.length; ii < l; ii++) {
-					if (linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber) > -1) {
-						followingNodesOnPage.push(linearNodeList[ii].nodeInfo);
-					}
-					if (linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber + 1) > -1) {
-						nodesOnNextPage.push(linearNodeList[ii].nodeInfo);
+				if(pageBreakBeforeFct.length>1){
+					for (var ii = index + 1, l = linearNodeList.length; ii < l; ii++) {
+						if (linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber) > -1) {
+							followingNodesOnPage.push(linearNodeList[ii].nodeInfo);
+						}
+						if (pageBreakBeforeFct.length>2&&linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber + 1) > -1) {
+							nodesOnNextPage.push(linearNodeList[ii].nodeInfo);
+						}
 					}
 				}
-				for (var ii = 0; ii < index; ii++) {
-					if (linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber) > -1) {
-						previousNodesOnPage.push(linearNodeList[ii].nodeInfo);
+				if(pageBreakBeforeFct.length>3){
+					for (var ii = 0; ii < index; ii++) {
+						if (linearNodeList[ii].nodeInfo.pageNumbers.indexOf(pageNumber) > -1) {
+							previousNodesOnPage.push(linearNodeList[ii].nodeInfo);
+						}
 					}
 				}
 				if (pageBreakBeforeFct(node.nodeInfo, followingNodesOnPage, nodesOnNextPage, previousNodesOnPage)) {

tests/layoutBuilder.js

@@ -1832,8 +1832,8 @@ describe('LayoutBuilder', function () {
 				{ text: 'Text 4 (Page 2)', id: 'text4', pageBreak: 'before' }
 			];
 
-			pageBreakBeforeFunction = sinon.spy();
-
+			function functionOfLength2(a,b) {}
+			pageBreakBeforeFunction = sinon.spy(functionOfLength2);
 
 			builder.layoutDocument(docStructure, fontProvider, styleDictionary, defaultStyle, background, header, footer, images, watermark, pageBreakBeforeFunction);
 
@@ -1851,8 +1851,8 @@ describe('LayoutBuilder', function () {
 				id: 'stack'
 			};
 
-			pageBreakBeforeFunction = sinon.spy();
-
+			function functionOfLength3(a,b,c) {}
+			pageBreakBeforeFunction = sinon.spy(functionOfLength3);
 
 			builder.layoutDocument(docStructure, fontProvider, styleDictionary, defaultStyle, background, header, footer, images, watermark, pageBreakBeforeFunction);
 
@@ -1870,8 +1870,8 @@ describe('LayoutBuilder', function () {
 				id: 'stack'
 			};
 
-			pageBreakBeforeFunction = sinon.spy();
-
+			function functionOfLength4(a,b,c,d) {}
+			pageBreakBeforeFunction = sinon.spy(functionOfLength4);
 
 			builder.layoutDocument(docStructure, fontProvider, styleDictionary, defaultStyle, background, header, footer, images, watermark, pageBreakBeforeFunction);