Improve comments generation #14979

liuxingbaoyu · 2022-09-27T15:42:35Z

Q	A
Fixed Issues?	Fixes #8684, Fixes #13904,Fixes #8437, Fixes #9547(This isn't technically 100%, but the example has been fixed)
Patch: Bug Fix?	?
Major: Breaking Change?
Minor: New Feature?	?
Tests Added + Pass?	√
Documentation PR Link
Any Dependency Changes?
License	MIT

This PR affects test snapshots as well as #14967, so I hope to release them together.（Perhaps the next patch release, we've had enough changes in this release that delaying these two avoids an unexpectedly large number of regressions that can't be dealt with on the fly.）

Please mainly check the first commit or use vscode for review.

I refactored the line break logic.
Multiple newlines are now no longer added except for comments.
There is at most one blank line before and after the comment.
Existing newlines are automatically subtracted when newline is called multiple times.
This keeps compiled comments well-formed (especially jsdoc, flow, certain directives like disable-next-line, disable-this-line).

Also I stopped adding extra line breaks depending on the node layout, so overall there is no performance hit and a small improvement.
The result looked fine to me and even got better looking in many files.
Because our newline addition logic has not been modified for a long time, it can only be adapted to several basic nodes.

In addition, I recommend viewing the effect through this file, which is very beautiful!
packages/babel-helpers/src/helpers/regeneratorRuntime.js (#14979)

The generator now uses node.loc and comment.loc.
The benefit is that it does not depend on a specific node type, and has good sustainability for the future.
The possible downside is that node.loc is used, which may prevent us from streamlining it in the future (e.g. making node.loc optional generation) it.
But node.loc should not be completely removed in the future, so this is all good.

liuxingbaoyu · 2022-09-27T15:44:38Z

...abel-plugin-proposal-json-strings/test/fixtures/json-strings/string-line-separator/output.js

 expect("\u2028".length).toBe(1);
 expect("\u2028").toBe("\u2028");
 expect("before\u2028after".length).toBe(12);
-expect("before\u2028after").toBe("before\u2028after"); //            ^ That's a U+2028 LINE SEPARATOR UTF-16 char (between 'before' and 'after')
+expect("before\u2028after").toBe("before\u2028after");
+//            ^ That's a U+2028 LINE SEPARATOR UTF-16 char (between 'before' and 'after')

 expect("\u2028".length).toBe(1);
-expect("\u2028").toBe("\u2028"); //      ^ That's a U+2028 LINE SEPARATOR UTF-16 char
+expect("\u2028").toBe("\u2028");
+//      ^ That's a U+2028 LINE SEPARATOR UTF-16 char

 expect("\ ".length).toBe(0);
-expect("\ ").toBe(""); //       ^ That's a U+2028 LINE SEPARATOR UTF-16 char
+expect("\ ").toBe("");
+//       ^ That's a U+2028 LINE SEPARATOR UTF-16 char

 expect("\\\u2028".length).toBe(2);
-expect("\\\u2028").toBe("\\\u2028"); //        ^ That's a U+2028 LINE SEPARATOR UTF-16 char
+expect("\\\u2028").toBe("\\\u2028");
+//        ^ That's a U+2028 LINE SEPARATOR UTF-16 char

 expect("\\\ ".length).toBe(1);
-expect("\\\ ").toBe("\\"); //         ^ That's a U+2028 LINE SEPARATOR UTF-16 char
+expect("\\\ ").toBe("\\");
+//         ^ That's a U+2028 LINE SEPARATOR UTF-16 char

 expect("\\\\\u2028".length).toBe(3);
-expect("\\\\\u2028").toBe("\\\\\u2028"); //          ^ That's a U+2028 LINE SEPARATOR UTF-16 char
+expect("\\\\\u2028").toBe("\\\\\u2028");
+//          ^ That's a U+2028 LINE SEPARATOR UTF-16 char


Exciting change.

babel-bot · 2022-09-27T15:45:53Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53120/

nicolo-ribaudo · 2022-10-03T09:21:51Z

packages/babel-generator/src/generators/base.ts

-
-    if (!this.endsWith(charCodes.lineFeed)) this.newline();
+  const newline = node.body.length ? 2 : 1;
+  const len = node.directives?.length || 0;


Nit: move newline inside the if statement, and rename len to directivesLen. I was initially confused to why we would need a newline in an empty block, until I realized that it's because the block contains directives.

Also, || 0 is not needed.

nicolo-ribaudo · 2022-10-03T09:22:49Z

packages/babel-generator/src/printer.ts

-      this.space();
-      return;
-    }
+    // if (this.format.retainLines || this.format.compact) return;


Is this code not needed anymore? If so, can yo write in a comment why are we commenting it out rather than just deleting it?

It seems like newline is just an alias for newlineRelative, why don't we only use one of them?

At first I wanted to make newlineRelative a new method, which would be clearer, and make newline another method with nuances, then switch most of the original usage to newlineRelative. Later it seemed unnecessary, and now I removed newline and renamed newlineRelative to that.

nicolo-ribaudo · 2022-10-03T09:24:40Z

packages/babel-generator/src/printer.ts

    // don't add newlines at the beginning of the file
    if (this._buf.hasContent()) {
-      if (!leading) lines++; // always include at least a single line after
-      if (opts.addNewlines) lines += opts.addNewlines(leading, node) || 0;
+      // let lines = 0;


Also here, why do we keep the old code?

This is the original logic of wrapping lines according to the node layout, and I'm a little hesitant to comment or remove them. It might be useful if someone wants to enhance or reference in the future, but not sure if that will happen.🤦‍♂️

nicolo-ribaudo · 2022-10-03T09:25:52Z

...ages/babel-generator/test/fixtures/comments/async-arrow-single-param-with-comments/output.js

+async ( /** @type {any} */arg) => {};
+async (arg /* trailing */) => {};
+async ( /** @type {any} */arg /* trailing */) => {};


nicolo-ribaudo · 2022-10-03T09:28:09Z

packages/babel-generator/test/fixtures/comments/variable-declarator-trailing-comment/output.js

+  var t = 20; /*
+             * This is trailing comment
+             */


The indentation here looks off 🤔 Is it possible to align the *s?

It seems to have exposed two previous issues, one from a regression from the last time I improved performance, and one that was always there, and now they're both fixed!

Also I found out that indenting var affects leadingComments.
Now the VariableDeclarator is no longer aligned, but indented by 2 spaces.
Now the indentation of var a={x},b={y} has been greatly improved, which I think looks good.

before

after

JLHwung · 2022-10-03T14:28:06Z

packages/babel-generator/src/printer.ts

+
+    i -= this._buf.getNewlineCount();
+
+    if (i <= 0) return i;


Nit: this line is redundant.

JLHwung · 2022-10-03T14:30:33Z

packages/babel-generator/src/printer.ts

+    node: t.Node | null,
+    parent?: t.Node,
+    noLineTerminator?: boolean,
+    trailingCommentsLineOffset?: number, // trailingCommentsLineOffset also used to check if called from printJoin


Can you leave a note that trailingCommentsLineOffset won't be respected if noLineTerminator or this._noLineTerminator is true?

liuxingbaoyu · 2022-10-03T18:33:16Z

packages/babel-generator/test/fixtures/comments/computed-property-comments-2/output.js

 var test = {
-  /**
-   * Before bracket init
-   */
-  ["a"]: "1",
-  [/*
-    * Inside bracket init
-    */
-  "b"]: "2"
-},
-    ok = 42;
+    /**
+     * Before bracket init
+     */
+    ["a"]: "1",
+    [
+    /*
+     * Inside bracket init
+     */
+    "b"]: "2",
+    [
+    /**
+     * Multi-line
+     */
+    "c"]: "3"
+  },
+  ok = 42;


looks great.

liuxingbaoyu · 2022-10-03T18:33:51Z

packages/babel-helpers/src/helpers/regeneratorRuntime.js

@@ -218,7 +220,8 @@ export default function _regeneratorRuntime() {
        // important to get this right, even though it requires care.
        previousPromise
          ? previousPromise.then(
-              callInvokeWithMethodAndArg, // Avoid propagating failures to Promises returned by later
+              callInvokeWithMethodAndArg,
+              // Avoid propagating failures to Promises returned by later
              // invocations of the iterator.
              callInvokeWithMethodAndArg,
            )


real world. :)

nicolo-ribaudo · 2022-10-03T19:03:18Z

packages/babel-core/test/fixtures/transformation/misc/regression-1155/output.js

-
-  return babelHelpers.createClass(Foo);
-}(Bar);
+    "use strict";


This is looks very unusual, the widely used convention is that it should be indented only by 1 step:

var f = function () { something; };

however, it's true that with multiple functions it looks better by indenting more:

var f = function () { something; }, g = function () { something; };

could we keep the original indentation if node.declarators.length === 1, and only use the more indented version when there are multiple declarators?

nicolo-ribaudo · 2022-10-03T20:56:45Z

Maybe we could try reducing a bit the diff, with heuristics like "if a function declaration, method, or variable declaration doesn't have any trailing comments, force an empty newline after it".

Otherwise LGTM (I cannot ✔️ because the diff is too big and the page freezes when I try to approve)

liuxingbaoyu · 2022-10-04T01:45:29Z

I thought about this at first, but maybe it's a little difficult or doesn't work very well.
A lot of the differences come from variable declarations, function calls, and function declarations.

Function calls I think it's nice to have no blank lines.

And function declarations are fine for no empty lines without decorators, but it would also be a bit ugly if we only wrap empty functions with decorators, and empty functions with decorators should be negligible in the real world.
I looked at the prettier and they also don't seem to force newlines on functions, with or without decorators. They'll just follow the original blank line, but that's not very suitable for babel.
Many babel statements are generated by the api, and even if the original blank line is also followed, the final output may not necessarily look good.

Previously variable declarations would be merged consecutively and only add a blank line.
I personally tend to have no blank lines >= consecutive being merged + one blank line > each with a blank line

var a;
var b;
var c;
var d;
var e;

var a;

var b;

var c;

var d;

var e;

What do you think about this?
By the way, if you use the web version of github, you can submit a review when viewing a single commit. :)

real world before and after

nicolo-ribaudo · 2022-10-04T14:49:59Z

There is a missing newline here: https://github.com/liuxingbaoyu/babel/blob/232fab424c40eb8e405a0fb801a17affc064dd32/packages/babel-plugin-transform-block-scoping/test/fixtures/general/issue-4363/output.js#L12

liuxingbaoyu · 2022-10-04T15:27:59Z

Good catch, fixed, thanks!

nicolo-ribaudo

I tried adding back spaces around function/class declarations and class methods: nicolo-ribaudo#8. I think it looks better, but it only reduced the changed files count by ~10%. Feel free to either add it to this PR or to ignore it.

liuxingbaoyu · 2022-10-04T18:19:28Z

Thanks for your experiment!
Most of the results are great, but some corner cases seem to be a little troublesome.
For example this.
These situations can be a little tricky to deal with, maybe we'll do it in the future?
I simply thought about it and tried it, but I didn't find a good and easy way to solve them completely, so I'm more inclined to maybe make a major change in the future. (I looked at the line break logic in the past, it's a bit complicated🤦‍♂️)

nicolo-ribaudo · 2022-10-09T15:20:55Z

Merging with a single ✔️, since it will be a while before that @JLHwung is back and I'm waiting for this to be merged to release and fix the ❌ on main 😅

liuxingbaoyu · 2022-10-09T23:07:44Z

ce886b5...b058e3b

For anyone who wants to see this PR in the future. Although not as convenient, it is at least viewable.🙂

pyramation · 2022-10-11T08:08:13Z

hey I'm now experiencing issues after this.

-/** CPU stores resource units and cpu config attributes */
-export interface CPU {
+/** CPU stores resource units and cpu config attributes */export interface CPU {
   units: ResourceValue;
   attributes: Attribute[];
 }

Is there an easy fix to add newlines for CommentBlock?

liuxingbaoyu · 2022-10-11T08:09:50Z

@pyramation This looks like a bug, can you provide a repl/repo to reproduce?

pyramation · 2022-10-11T08:13:15Z

sure for now I'll leave more info here. It is a leadingComment (CommentBlock):

/** CPU stores resource units and cpu config attributes */
export interface CPU {
    units: ResourceValue;
    attributes: Attribute[];
}

{
  "type": "File",
  "errors": [],
  "program": {
    "type": "Program",
    "sourceType": "module",
    "interpreter": null,
    "body": [
      {
        "type": "ExportNamedDeclaration",
        "exportKind": "type",
        "specifiers": [],
        "source": null,
        "declaration": {
          "type": "TSInterfaceDeclaration",
          "id": {
            "type": "Identifier",
            "name": "CPU"
          },
          "body": {
            "type": "TSInterfaceBody",
            "body": [
              {
                "type": "TSPropertySignature",
                "key": {
                  "type": "Identifier",
                  "name": "units"
                },
                "computed": false,
                "typeAnnotation": {
                  "type": "TSTypeAnnotation",
                  "typeAnnotation": {
                    "type": "TSTypeReference",
                    "typeName": {
                      "type": "Identifier",
                      "name": "ResourceValue"
                    }
                  }
                }
              },
              {
                "type": "TSPropertySignature",
                "key": {
                  "type": "Identifier",
                  "name": "attributes"
                },
                "computed": false,
                "typeAnnotation": {
                  "type": "TSTypeAnnotation",
                  "typeAnnotation": {
                    "type": "TSArrayType",
                    "elementType": {
                      "type": "TSTypeReference",
                      "typeName": {
                        "type": "Identifier",
                        "name": "Attribute"
                      }
                    }
                  }
                }
              }
            ]
          }
        },
        "leadingComments": [
          {
            "type": "CommentBlock",
            "value": "* CPU stores resource units and cpu config attributes "
          }
        ]
      }
    ],
    "directives": []
  },
  "comments": [
    {
      "type": "CommentBlock",
      "value": "* CPU stores resource units and cpu config attributes "
    }
  ]
}

pyramation · 2022-10-11T08:37:03Z

@liuxingbaoyu I made a repo for repro:

https://github.com/pyramation/babel-issue-15036

the breaking commit is when I upgrade babel: pyramation/babel-issue-15036@e298022

You can see leading comments lose their trailing newlines

liuxingbaoyu · 2022-10-11T09:02:41Z

@pyramation Ok thanks, i will look into it.

<h3>Snyk has created this PR to upgrade multiple dependencies.</h3> 👯‍♂ The following dependencies are linked and will therefore be updated together. </br></br> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. </br></br> Name | Versions | Released on :-------------|:-------------|:------------- **@babel/core**</br>from 7.19.6 to 7.20.2 | **1 version** ahead of your current version | **21 days ago**</br>on 2022-11-04 **@babel/preset-env**</br>from 7.19.4 to 7.20.2 | **1 version** ahead of your current version | **21 days ago**</br>on 2022-11-04 <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@babel/core</b></summary> <ul> <li> <b>7.20.2</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.20.2">2022-11-04</a></br><h2>v7.20.2 (2022-11-04)</h2> <h4><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Bug Fix</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-helper-plugin-utils</code>, <code>babel-helper-simple-access</code>, <code>babel-node</code>, <code>babel-plugin-transform-block-scoping</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-preset-env</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15124" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15124/hovercard">#15124</a> fix: <code>@ babel/node</code> repl and enable <code>no-use-before-define</code> rule (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15121" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15121/hovercard">#15121</a> fix: <code>tsSatisfiesExpression</code> check with different duplicated <code>@ babel/types</code> versions (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15094" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15094/hovercard">#15094</a> fix: <code>parser</code> typings for plugins (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-generator</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15118" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15118/hovercard">#15118</a> Improve printing of [no LineTerminator here] with comments (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-proposal-object-rest-spread</code>, <code>babel-plugin-transform-jscript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15113" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15113/hovercard">#15113</a> fix: wrap anonymous class expression within statement (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-transform-destructuring</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15104" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15104/hovercard">#15104</a> fix: Destructuring exceptions <code>for ( let { } = 0 ; 0 ; ) </code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.19.6</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.19.6">2022-10-20</a></br><h2>v7.19.6 (2022-10-20)</h2> <p>Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/lomirus/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/lomirus">@ lomirus</a> for your first PR!</p> <h4><g-emoji class="g-emoji" alias="eyeglasses" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f453.png">👓</g-emoji> Spec Compliance</h4> <ul> <li><code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15059" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15059/hovercard">#15059</a> Ensure non-static decorators are applied when a class is instantiated. (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15062" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15062/hovercard">#15062</a> Fix parsing of block comments nested in flow comments (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15052" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15052/hovercard">#15052</a> fix: improve module block program location tracking (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-transform-runtime</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15060" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15060/hovercard">#15060</a> Ensure <code>@ babel/runtime-corejs3/core-js/*.js</code> can be imported on Node.js 17+ (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-preset-env</code>, <code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15043" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15043/hovercard">#15043</a> fix: preserve this for <code>super.*</code> template tags (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="nail_care" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f485.png">💅</g-emoji> Polish</h4> <ul> <li><code>babel-generator</code>, <code>babel-plugin-transform-flow-comments</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15037" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15037/hovercard">#15037</a> Improve generation of comments without location (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="memo" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4dd.png">📝</g-emoji> Documentation</h4> <ul> <li><code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15055" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15055/hovercard">#15055</a> Fix missing <code>transformSync</code> function name (<a href="https://snyk.io/redirect/github/lomirus">@ lomirus</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="house" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f3e0.png">🏠</g-emoji> Internal</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15056" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15056/hovercard">#15056</a> Use <code>startLoc.index</code> instead of carrying around <code>start</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15035" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15035/hovercard">#15035</a> chore: Update yarn 3.2.4 (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="running_woman" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f3c3-2640.png">🏃‍♀️</g-emoji> Performance</h4> <ul> <li><code>babel-core</code>, <code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15023" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15023/hovercard">#15023</a> Don't bundle unnecessary plugins in <code>@ babel/standalone</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 4</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Lomírus (<a href="https://snyk.io/redirect/github/lomirus">@ lomirus</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/core GitHub release notes</a> </details> <details> <summary>Package name: <b>@babel/preset-env</b></summary> <ul> <li> <b>7.20.2</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.20.2">2022-11-04</a></br><h2>v7.20.2 (2022-11-04)</h2> <h4><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Bug Fix</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-module-transforms</code>, <code>babel-helper-plugin-utils</code>, <code>babel-helper-simple-access</code>, <code>babel-node</code>, <code>babel-plugin-transform-block-scoping</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-preset-env</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15124" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15124/hovercard">#15124</a> fix: <code>@ babel/node</code> repl and enable <code>no-use-before-define</code> rule (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15121" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15121/hovercard">#15121</a> fix: <code>tsSatisfiesExpression</code> check with different duplicated <code>@ babel/types</code> versions (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15094" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15094/hovercard">#15094</a> fix: <code>parser</code> typings for plugins (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-generator</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15118" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15118/hovercard">#15118</a> Improve printing of [no LineTerminator here] with comments (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-proposal-object-rest-spread</code>, <code>babel-plugin-transform-jscript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15113" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15113/hovercard">#15113</a> fix: wrap anonymous class expression within statement (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-transform-destructuring</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15104" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15104/hovercard">#15104</a> fix: Destructuring exceptions <code>for ( let { } = 0 ; 0 ; ) </code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.19.4</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.19.4">2022-10-10</a></br><h2>v7.19.4 (2022-10-10)</h2> <h4><g-emoji class="g-emoji" alias="eyeglasses" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f453.png">👓</g-emoji> Spec Compliance</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15019" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15019/hovercard">#15019</a> fix: check constant violation inside loops (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-object-rest-spread</code>, <code>babel-plugin-transform-destructuring</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14985" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14985/hovercard">#14985</a> Disallow rest object destructuring of null/undefined (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Bug Fix</h4> <ul> <li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14109" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14109/hovercard">#14109</a> Fix: properly scope variables in TSModuleBlock (<a href="https://snyk.io/redirect/github/The-x-Theorist">@ The-x-Theorist</a>)</li> </ul> </li> <li><code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15027" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15027/hovercard">#15027</a> fix: mark <code>var</code> declarations in loops as not constant (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helper-string-parser</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14964" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14964/hovercard">#14964</a> Never throw for invalid escapes in tagged templates (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14980" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14980/hovercard">#14980</a> Improve module expression parsing/printing (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-plugin-transform-destructuring</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14984" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14984/hovercard">#14984</a> Fix holes handling in optimized array destructuring (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="nail_care" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f485.png">💅</g-emoji> Polish</h4> <ul> <li><code>babel-cli</code>, <code>babel-core</code>, <code>babel-generator</code>, <code>babel-helper-create-class-features-plugin</code>, <code>babel-helper-fixtures</code>, <code>babel-helper-simple-access</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-helpers</code>, <code>babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression</code>, <code>babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining</code>, <code>babel-plugin-external-helpers</code>, <code>babel-plugin-proposal-async-do-expressions</code>, <code>babel-plugin-proposal-async-generator-functions</code>, <code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-proposal-class-static-block</code>, <code>babel-plugin-proposal-decorators</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-do-expressions</code>, <code>babel-plugin-proposal-duplicate-named-capturing-groups-regex</code>, <code>babel-plugin-proposal-dynamic-import</code>, <code>babel-plugin-proposal-function-bind</code>, <code>babel-plugin-proposal-function-sent</code>, <code>babel-plugin-proposal-json-strings</code>, <code>babel-plugin-proposal-logical-assignment-operators</code>, <code>babel-plugin-proposal-nullish-coalescing-operator</code>, <code>babel-plugin-proposal-object-rest-spread</code>, <code>babel-plugin-proposal-optional-chaining</code>, <code>babel-plugin-proposal-partial-application</code>, <code>babel-plugin-proposal-pipeline-operator</code>, <code>babel-plugin-proposal-private-methods</code>, <code>babel-plugin-proposal-private-property-in-object</code>, <code>babel-plugin-proposal-record-and-tuple</code>, <code>babel-plugin-syntax-typescript</code>, <code>babel-plugin-transform-arrow-functions</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-block-scoping</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-computed-properties</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-duplicate-keys</code>, <code>babel-plugin-transform-exponentiation-operator</code>, <code>babel-plugin-transform-flow-comments</code>, <code>babel-plugin-transform-flow-strip-types</code>, <code>babel-plugin-transform-for-of</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-jscript</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-new-target</code>, <code>babel-plugin-transform-object-super</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-proto-to-assign</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>, <code>babel-plugin-transform-react-pure-annotations</code>, <code>babel-plugin-transform-regenerator</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-shorthand-properties</code>, <code>babel-plugin-transform-spread</code>, <code>babel-plugin-transform-strict-mode</code>, <code>babel-plugin-transform-template-literals</code>, <code>babel-plugin-transform-typeof-symbol</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-plugin-transform-unicode-escapes</code>, <code>babel-preset-env</code>, <code>babel-preset-react</code>, <code>babel-preset-typescript</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14979" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14979/hovercard">#14979</a> Improve comments generation (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-cli</code>, <code>babel-core</code>, <code>babel-generator</code>, <code>babel-helper-fixtures</code>, <code>babel-helper-transform-fixture-test-runner</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14967" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14967/hovercard">#14967</a> Improve source map generation (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4><g-emoji class="g-emoji" alias="house" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f3e0.png">🏠</g-emoji> Internal</h4> <ul> <li>Other <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15001" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15001/hovercard">#15001</a> Run test262 again (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-compat-data</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/14976" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/14976/hovercard">#14976</a> Internally rename <code>proposal-*</code> to <code>transform-*</code> in preset-env (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li>Sneh Khatri (<a href="https://snyk.io/redirect/github/The-x-Theorist">@ The-x-Theorist</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/preset-env GitHub release notes</a> </details> </details> <hr/> **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.* For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJlMmVmY2U2Zi04MDVjLTQwNzMtOWIyMS0wYWIzOGU2NzYzNWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImUyZWZjZTZmLTgwNWMtNDA3My05YjIxLTBhYjM4ZTY3NjM1ZSJ9fQ==" width="0" height="0"/> 🧐 [View latest project report](https://app.snyk.io/org/sandbox-2ba/project/852e6e4f-be96-45c8-b370-1060f5ebee55?utm_source=github&utm_medium=referral&page=upgrade-pr) 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/sandbox-2ba/project/852e6e4f-be96-45c8-b370-1060f5ebee55/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/sandbox-2ba/project/852e6e4f-be96-45c8-b370-1060f5ebee55/settings/integration?pkg=@babel/core&pkg=@babel/preset-env&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)  Co-authored-by: snyk-bot <snyk-bot@snyk.io>

liuxingbaoyu commented Sep 27, 2022

View reviewed changes

liuxingbaoyu marked this pull request as draft September 27, 2022 15:51

liuxingbaoyu force-pushed the improve-comments branch from 02d54d3 to 3550688 Compare October 2, 2022 21:08

liuxingbaoyu marked this pull request as ready for review October 2, 2022 21:49

liuxingbaoyu added pkg: generator area: comments labels Oct 2, 2022

nicolo-ribaudo reviewed Oct 3, 2022

View reviewed changes

JLHwung reviewed Oct 3, 2022

View reviewed changes

liuxingbaoyu commented Oct 3, 2022

View reviewed changes

nicolo-ribaudo reviewed Oct 3, 2022

View reviewed changes

nicolo-ribaudo approved these changes Oct 4, 2022

View reviewed changes

nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Oct 4, 2022

liuxingbaoyu mentioned this pull request Oct 6, 2022

Support more inner comments #15008

Merged

nicolo-ribaudo requested a review from JLHwung October 7, 2022 09:55

code

aa6a8fd

nicolo-ribaudo force-pushed the improve-comments branch from b058e3b to aa6a8fd Compare October 9, 2022 14:51

Fix helper-simple-access tests

90e2e44

nicolo-ribaudo changed the title ~~fix: Improve comments generation~~ Improve comments generation Oct 9, 2022

nicolo-ribaudo merged commit d45d59a into babel:main Oct 9, 2022

liuxingbaoyu mentioned this pull request Oct 10, 2022

Improve module expression parsing/printing #14980

Merged

pyramation mentioned this pull request Oct 11, 2022

[Bug]: whitespace issue with CommentBlock introduced after new PR #15036

Closed

1 task

liuxingbaoyu mentioned this pull request Oct 20, 2022

[Bug]: line feeds without comments are being suppressed #15064

Closed

1 task

shaneomatz mentioned this pull request Nov 18, 2022

[Snyk] Upgrade @babel/runtime from 7.12.5 to 7.20.0 shaneomatz/video.js#1

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 11, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve comments generation #14979

Improve comments generation #14979

liuxingbaoyu commented Sep 27, 2022 •

edited

liuxingbaoyu Sep 27, 2022

babel-bot commented Sep 27, 2022 •

edited

nicolo-ribaudo Oct 3, 2022

nicolo-ribaudo Oct 3, 2022

liuxingbaoyu Oct 3, 2022

nicolo-ribaudo Oct 3, 2022

liuxingbaoyu Oct 3, 2022

nicolo-ribaudo Oct 3, 2022

nicolo-ribaudo Oct 3, 2022

liuxingbaoyu Oct 3, 2022 •

edited

JLHwung Oct 3, 2022

JLHwung Oct 3, 2022

liuxingbaoyu Oct 3, 2022

liuxingbaoyu Oct 3, 2022

nicolo-ribaudo Oct 3, 2022

nicolo-ribaudo commented Oct 3, 2022

liuxingbaoyu commented Oct 4, 2022

nicolo-ribaudo commented Oct 4, 2022

liuxingbaoyu commented Oct 4, 2022

nicolo-ribaudo left a comment

liuxingbaoyu commented Oct 4, 2022 •

edited

nicolo-ribaudo commented Oct 9, 2022

liuxingbaoyu commented Oct 9, 2022

pyramation commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

pyramation commented Oct 11, 2022

pyramation commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

Improve comments generation #14979

Improve comments generation #14979

Conversation

liuxingbaoyu commented Sep 27, 2022 • edited

Choose a reason for hiding this comment

babel-bot commented Sep 27, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuxingbaoyu Oct 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Oct 3, 2022

liuxingbaoyu commented Oct 4, 2022

nicolo-ribaudo commented Oct 4, 2022

liuxingbaoyu commented Oct 4, 2022

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

liuxingbaoyu commented Oct 4, 2022 • edited

nicolo-ribaudo commented Oct 9, 2022

liuxingbaoyu commented Oct 9, 2022

pyramation commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

pyramation commented Oct 11, 2022

pyramation commented Oct 11, 2022

liuxingbaoyu commented Oct 11, 2022

liuxingbaoyu commented Sep 27, 2022 •

edited

babel-bot commented Sep 27, 2022 •

edited

liuxingbaoyu Oct 3, 2022 •

edited

liuxingbaoyu commented Oct 4, 2022 •

edited