fix: parse a<b>>>c as a<(b>>>c) #14819
Merged
+128
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52818/ |
JLHwung
commented
Aug 2, 2022
| @@ -0,0 +1 @@ | |||
| a<b> > c; | |||
There was a problem hiding this comment.
The current TS nightly throws "Expression expected" in this case and the other similar one, which I think is a TS bug. They should be handled as same as a<b> ?? c.
There was a problem hiding this comment.
It looks like this is intentional: microsoft/TypeScript#49353 (cc @ahejlsberg the code above is unambiguous, do you remember why it's disallowed?).
liuxingbaoyu
approved these changes
Aug 3, 2022
|
Let's merge it? |
|
I think we should match TS in #14819 (comment), since it's an intentional restriction. |
nicolo-ribaudo
approved these changes
Aug 27, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bail out the
TSInstantiateExpressiontry parsing when we see>>immediately after>without whitespaces.