File tree 2 files changed +19
-1
lines changed
packages/middleware-sdk-s3/src
2 files changed +19
-1
lines changed Original file line number Diff line number Diff line change @@ -35,6 +35,24 @@ describe("checkContentLengthHeaderMiddleware", () => {
35
35
) ;
36
36
} ) ;
37
37
38
+ it ( "does not warn if uploading a payload of content-length 0" , async ( ) => {
39
+ const handler = checkContentLengthHeader ( ) ( mockNextHandler , { } ) ;
40
+
41
+ await handler ( {
42
+ request : {
43
+ method : null ,
44
+ protocol : null ,
45
+ hostname : null ,
46
+ path : null ,
47
+ query : { } ,
48
+ headers : { "content-length" : 0 } ,
49
+ } ,
50
+ input : { } ,
51
+ } ) ;
52
+
53
+ expect ( spy ) . not . toHaveBeenCalled ( ) ;
54
+ } ) ;
55
+
38
56
it ( "warns with console if logger is the default NoOpLogger" , async ( ) => {
39
57
const handler = checkContentLengthHeader ( ) ( mockNextHandler , {
40
58
logger : new NoOpLogger ( ) ,
Original file line number Diff line number Diff line change @@ -28,7 +28,7 @@ export function checkContentLengthHeader(): FinalizeRequestMiddleware<any, any>
28
28
const { request } = args ;
29
29
30
30
if ( HttpRequest . isInstance ( request ) ) {
31
- if ( ! request . headers [ CONTENT_LENGTH_HEADER ] ) {
31
+ if ( ! ( CONTENT_LENGTH_HEADER in request . headers ) ) {
32
32
const message = `Are you using a Stream of unknown length as the Body of a PutObject request? Consider using Upload instead from @aws-sdk/lib-storage.` ;
33
33
if ( typeof context ?. logger ?. warn === "function" && ! ( context . logger instanceof NoOpLogger ) ) {
34
34
context . logger . warn ( message ) ;
You can’t perform that action at this time.
0 commit comments