Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: avajs/ava
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.0
Choose a base ref
...
head repository: avajs/ava
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 6, 2023

  1. Ensure watch mode works outside of its integration tests 

    Somewhere between developing the watch mode and adding test coverage, a mechanism was introduced to control watch mode in its integration tests. Ironically watch mode relied on this mechanism and no longer worked in actual use.

Fixes #3270
    @novemberborn
    novemberborn authored Dec 6, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    32f282f View commit details

  2. 6.0.1

    @novemberborn
    novemberborn committed Dec 6, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    novemberborn Mark Wubben
    SSH Key Fingerprint: vMGPTCc4s8qHvUbwn+BG4sx8ahyNN/1R52XsxINSNVk
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5975b60 View commit details
Showing with 7 additions and 7 deletions.
  1. +1 −1 lib/cli.js
  2. +3 −3 lib/watcher.js
  3. +2 −2 package-lock.json
  4. +1 −1 package.json
2 changes: 1 addition & 1 deletion lib/cli.js
View file
Original file line number Diff line number Diff line change
@@ -522,7 +522,7 @@ export default async function loadCli() { // eslint-disable-line complexity
providers,
reporter,
stdin: process.stdin,
signal: abortController.signal,
signal: abortController?.signal,
});
} else {
let debugWithoutSpecificFile = false;
6 changes: 3 additions & 3 deletions lib/watcher.js
View file
Original file line number Diff line number Diff line change
@@ -370,15 +370,15 @@ async function * plan({api, filter, globs, projectDir, providers, stdin, abortSi
}
});

abortSignal.addEventListener('abort', () => {
abortSignal?.addEventListener('abort', () => {
signalChanged?.({});
});

// And finally, the watch loop.
while (!abortSignal.aborted) {
while (abortSignal?.aborted !== true) {
const {testFiles: files = [], runOnlyExclusive = false} = await changed; // eslint-disable-line no-await-in-loop

if (abortSignal.aborted) {
if (abortSignal?.aborted) {
break;
}

4 changes: 2 additions & 2 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ava",
"version": "6.0.0",
"version": "6.0.1",
"description": "Node.js test runner that lets you develop with confidence.",
"license": "MIT",
"repository": "avajs/ava",