Use configured depth limit for diffs in assertion failures

Author: bunysae

lib/assert.js

@@ -3,11 +3,10 @@ const concordance = require('concordance');
 const isError = require('is-error');
 const isPromise = require('is-promise');
 const concordanceOptions = require('./concordance-options').default;
-const concordanceDiffOptions = require('./concordance-options').diff;
 const snapshotManager = require('./snapshot-manager');
 
 function formatDescriptorDiff(actualDescriptor, expectedDescriptor, options) {
-	options = {...options, ...concordanceDiffOptions};
+	options = {...options, ...concordanceOptions};
 	return {
 		label: 'Difference:',
 		formatted: concordance.diffDescriptors(actualDescriptor, expectedDescriptor, options)

lib/concordance-options.js

@@ -135,5 +135,4 @@ exports.default = {
 	theme
 };
 
-exports.diff = {maxDepth: 1, plugins, theme};
 exports.snapshotManager = {plugins, theme: plainTheme};

test-tap/fixture/report/regular/nested-objects.js

@@ -0,0 +1,29 @@
+const test = require('../../../..');
+const util = require('util');
+
+util.inspect.defaultOptions.depth = 4;
+
+test('format with max depth 4', t => {
+	const exp = {
+		a: {
+			b: {
+				foo: 'bar'
+			}
+		}
+	};
+	const act = {
+		a: {
+			b: {
+				foo: 'bar'
+			}
+		},
+		c: {
+			d: {
+				e: {
+					foo: 'bar'
+				}
+			}
+		}
+	};
+	t.deepEqual(exp, act);
+});

test-tap/reporters/mini.regular.v10.log

@@ -3,161 +3,166 @@
 ---tty-stream-chunk-separator
 * ---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
-* output-in-hook › passing test
+* nested-objects › format with max depth 4
 
-  1 passed---tty-stream-chunk-separator
+  1 test failed---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
-* output-in-hook › failing test
+* output-in-hook › passing test
 
   1 passed
   1 test failed---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
+* output-in-hook › failing test
+
+  1 passed
+  2 tests failed---tty-stream-chunk-separator
+---tty-stream-chunk-separator
 * test › passes
 
   2 passed
-  1 test failed
+  2 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › fails
 
   2 passed
-  2 tests failed
+  3 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › known failure
 
   2 passed
   1 known failure
-  2 tests failed
+  3 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › no longer failing
 
   2 passed
   1 known failure
-  3 tests failed
+  4 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › logs
 
   2 passed
   1 known failure
-  4 tests failed
+  5 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › formatted
 
   2 passed
   1 known failure
-  5 tests failed
+  6 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › power-assert
 
   2 passed
   1 known failure
-  6 tests failed
+  7 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › bad throws
 
   2 passed
   1 known failure
-  7 tests failed
+  8 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › bad notThrows
 
   2 passed
   1 known failure
-  8 tests failed
+  9 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * test › implementation throws non-error
 
   2 passed
   1 known failure
-  9 tests failed
+  10 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * traces-in-t-throws › throws
 
   2 passed
   1 known failure
-  10 tests failed
+  11 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * traces-in-t-throws › notThrows
 
   2 passed
   1 known failure
-  11 tests failed
+  12 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * traces-in-t-throws › notThrowsAsync
 
   2 passed
   1 known failure
-  12 tests failed
+  13 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * traces-in-t-throws › throwsAsync
 
   2 passed
   1 known failure
-  13 tests failed
+  14 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * traces-in-t-throws › throwsAsync different error
 
   2 passed
   1 known failure
-  14 tests failed
+  15 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * uncaught-exception › passes
 
   3 passed
   1 known failure
-  14 tests failed
+  15 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * unhandled-rejection › passes
 
   4 passed
   1 known failure
-  14 tests failed
+  15 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 * unhandled-rejection › unhandled non-error rejection
 
   5 passed
   1 known failure
-  14 tests failed
+  15 tests failed
   1 skipped
   1 todo---tty-stream-chunk-separator
 ---tty-stream-chunk-separator
 [?25h
   ✖ No tests found in bad-test-chain.js
 
-  14 tests failed
+  15 tests failed
   1 known failure
   1 test skipped
   1 test todo
@@ -166,6 +171,36 @@
 
   test › known failure
 
+  nested-objects › format with max depth 4
+
+  nested-objects.js:28
+
+   27:   };                    
+   28:   t.deepEqual(exp, act);
+   29: });                     
+
+  Difference:
+
+    {
+      a: {
+        b: {
+          foo: 'bar',
+        },
+      },
+  +   c: {
+  +     d: {
+  +       e: {
+  +         foo: 'bar',
+  +       },
+  +     },
+  +   },
+    }
+
+  › t (test-tap/fixture/report/regular/nested-objects.js:28:4)
+  › process._tickCallback (internal/process/next_tick.js:68:7)
+
+
+
   output-in-hook › failing test
 
   output-in-hook.js:34