[SDK-2833] Fix issue where errors were being cached #268
+43
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the
sync
lru-memoizer
was caching the promise per kid, rather than the result of the promise perkid
. So if the first request failed, the rejected promise would stay in the cache and be reused for subsequent requests.Have switched to the
async
lru-memoizer
which caches the result of the async function, so if the async function fails the result will not be cached. This required a callback type signature funciton and returned a callback signature function. So the input promise function needed to be callbackified, and the output callback function needed to be promisified.References
fixes #257
Testing
Checklist
master