full JWK/JWS support #205
Merged
full JWK/JWS support #205
+411
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for pushing the change! |
davidpatrick
previously approved these changes
Jan 4, 2021
adamjmcgrath
previously approved these changes
Jan 5, 2021
davidpatrick
dismissed stale reviews from adamjmcgrath and themself
via
7d6d795
davidpatrick
previously approved these changes
Jan 7, 2021
davidpatrick
approved these changes
Jan 7, 2021
|
@davidpatrick thanks for the pushing the project forward! I see there is a next milestone https://github.com/auth0/node-jwks-rsa/milestone/7?closed=1 |
|
@ivn-cote sorry for the delay on this, we are moving forward with this release this week |
This was referenced Feb 23, 2021
Merged
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains support for all currently registered JWK types and JWS Algorithms.
References
Checklist
masterCloses #170
Closes #40
Closes #50
Closes #11
Credit goes to @ivn-cote for his work on #170. Note that, just like #170 this warrants a new major release due to dependency's node runtime requirements, the removal of
nbfpassthrough (nbfon a JWK isn't standardized) as well as proper JWK parsing rules put forth by the inclusion ofjose.