Merge pull request #268 from auth0/no-cache-errors

[SDK-2833] Fix issue where errors were being cached

Author: adamjmcgrath

package-lock.json

@@ -24,6 +24,7 @@
     "@types/nock": "^11.0.0",
     "@types/node": "^14.14.12",
     "chai": "^3.5.0",
+    "chai-as-promised": "^7.1.1",
     "eslint": "^5.16.0",
     "express": "^4.17.1",
     "express-jwt": "^6.0.0",

package.json

@@ -1,14 +1,15 @@
 const logger = require('debug')('jwks');
 const memoizer = require('lru-memoizer');
+const { promisify, callbackify } = require('util');
 
 function cacheWrapper(client, { cacheMaxEntries = 5, cacheMaxAge = 600000 }) {
   logger(`Configured caching of signing keys. Max: ${cacheMaxEntries} / Age: ${cacheMaxAge}`);
-  return memoizer.sync({
+  return promisify(memoizer({
     hash: (kid) => kid,
-    load: client.getSigningKey.bind(client),
+    load: callbackify(client.getSigningKey.bind(client)),
     maxAge: cacheMaxAge,
     max: cacheMaxEntries
-  });
+  }));
 }
 
 module.exports.default = cacheWrapper;

src/wrappers/cache.js

@@ -1,5 +1,5 @@
 const nock = require('nock');
-const { expect } = require('chai');
+const { expect } = require('chai').use(require('chai-as-promised'));
 
 const { x5cMultiple } = require('./keys');
 const { JwksClient } = require('../src/JwksClient');
@@ -361,13 +361,13 @@ describe('JwksClient', () => {
         expect(err.name).to.equal('JwksError');
         expect(err.message).to.equal(
           'The JWKS endpoint did not contain any signing keys'
-        ); 
+        );
       }
     });
 
     it('should handle errors passed from the interceptor', async () => {
       const error = new Error('interceptor error');
-      const client = new JwksClient({ 
+      const client = new JwksClient({
         jwksUri: 'http://invalidUri',
         getKeysInterceptor: () => { throw error; }
       });
@@ -388,7 +388,7 @@ describe('JwksClient', () => {
         nock(jwksHost)
           .get('/.well-known/jwks.json')
           .reply(200, x5cMultiple);
-  
+
         const client = new JwksClient({
           jwksUri: `${jwksHost}/.well-known/jwks.json`
         });
@@ -404,11 +404,11 @@ describe('JwksClient', () => {
         nock(jwksHost)
           .get('/.well-known/jwks.json')
           .reply(200, x5cMultiple);
-  
+
         const client = new JwksClient({
           jwksUri: `${jwksHost}/.well-known/jwks.json`
         });
-  
+
         client.getSigningKey('123', (err) => {
           expect(err).not.to.be.null;
           expect(err.name).to.equal('SigningKeyNotFoundError');
@@ -454,5 +454,22 @@ describe('JwksClient', () => {
         expect(err.message).to.equal('Http Error 500');
       }
     });
+
+    it('should not cache errors', async () => {
+      nock(jwksHost)
+        .get('/.well-known/jwks.json')
+        .reply(500);
+      nock(jwksHost)
+        .get('/.well-known/jwks.json')
+        .reply(200, x5cMultiple);
+
+      const client = new JwksClient({
+        jwksUri: `${jwksHost}/.well-known/jwks.json`
+      });
+
+      const kid = x5cMultiple.keys[0].kid;
+      await expect(client.getSigningKey(kid)).to.eventually.be.rejectedWith('Http Error 500');
+      await expect(client.getSigningKey(kid)).to.eventually.have.property('kid', kid);
+    });
   });
 });