Removed extendNodeEncodings mechanism. It didn't work in Node v4+ and was deprecated 5 years ago in v0.4.12.

Author: ashtuchkin

README.md

@@ -6,7 +6,6 @@
  * Faster than [node-iconv](https://github.com/bnoordhuis/node-iconv) (see below for performance comparison).
  * Intuitive encode/decode API
  * Streaming support for Node v0.10+
- * [Deprecated] Can extend Node.js primitives (buffers, streams) to support all iconv-lite encodings.
  * In-browser usage via [Browserify](https://github.com/substack/node-browserify) (~180k gzip compressed with Buffer shim included).
  * Typescript [type definition file](https://github.com/ashtuchkin/iconv-lite/blob/master/lib/index.d.ts) included.
  * React Native is supported (need to explicitly `npm install` two more modules: `buffer` and `stream`).
@@ -61,40 +60,6 @@ http.createServer(function(req, res) {
 });
 ```
 
-### [Deprecated] Extend Node.js own encodings
-> NOTE: This doesn't work on latest Node versions. See [details](https://github.com/ashtuchkin/iconv-lite/wiki/Node-v4-compatibility).
-
-```javascript
-// After this call all Node basic primitives will understand iconv-lite encodings.
-iconv.extendNodeEncodings();
-
-// Examples:
-buf = new Buffer(str, 'win1251');
-buf.write(str, 'gbk');
-str = buf.toString('latin1');
-assert(Buffer.isEncoding('iso-8859-15'));
-Buffer.byteLength(str, 'us-ascii');
-
-http.createServer(function(req, res) {
-    req.setEncoding('big5');
-    req.collect(function(err, body) {
-        console.log(body);
-    });
-});
-
-fs.createReadStream("file.txt", "shift_jis");
-
-// External modules are also supported (if they use Node primitives, which they probably do).
-request = require('request');
-request({
-    url: "http://github.com/", 
-    encoding: "cp932"
-});
-
-// To remove extensions
-iconv.undoExtendNodeEncodings();
-```
-
 ## Supported encodings
 
  *  All node.js native encodings: utf8, ucs2 / utf16-le, ascii, binary, base64, hex.

lib/extend-node.js

@@ -143,9 +143,6 @@ if (nodeVer) {
     if (nodeVerArr[0] > 0 || nodeVerArr[1] >= 10) {
         require("./streams")(iconv);
     }
-
-    // Load Node primitive extensions.
-    require("./extend-node")(iconv);
 }
 
 if ("Ā" != "\u0100") {

lib/index.js

@@ -1,7 +1,7 @@
 {
     "name": "iconv-lite",
     "description": "Convert character encodings in pure javascript.",
-    "version": "0.5.2",
+    "version": "0.6.0-pre",
     "license": "MIT",
     "keywords": [
         "iconv",
@@ -26,7 +26,6 @@
         "test": "mocha --reporter spec --grep ."
     },
     "browser": {
-        "./lib/extend-node": false,
         "./lib/streams": false
     },
     "devDependencies": {

package.json

@@ -51,9 +51,8 @@ describe("Full Browserify tests", function() {
             assert.equal(browserIconvLite.encode("中国", 'gbk').toString('hex'), "d6d0b9fa");
             assert.equal(browserIconvLite.decode(new browserBuffer("d6d0b9fa", 'hex'), 'gbk'), "中国");
 
-            // Test that streaming and extend-node API-s are not present.
+            // Test that streaming API-s are not present.
             assert(data.indexOf('encodeStream') == -1);
-            assert(data.indexOf('extendNodeEncodings') == -1);
 
             done();
         });