Skip to content

Commit 99ebec9

Browse files
committedAug 22, 2015
back out of new plugins to cut a stable release.
1 parent 3551c02 commit 99ebec9

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed
 

‎README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,11 @@ Sets the fs stat data for this entry. This allows for reduction of fs stat calls
215215

216216
## Custom Formats
217217

218-
Archiver ships with out of the box support for TAR and ZIP archives. You can register additional formats with `registerFormat`.
218+
Archiver ships with out of the box support for TAR and ZIP archives.
219+
220+
You can register additional formats with `registerFormat`.
221+
222+
_Formats will be changing in the next few releases to implement a middleware approach._
219223

220224
## Libraries
221225

‎lib/core.js

+2-17
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ var async = require('async');
99
var fs = require('fs');
1010
var util = require('./util');
1111

12-
// built-in plugins
13-
var pjson = require('archiver-json');
14-
var ptar = require('archiver-tar');
15-
var pzip = require('archiver-zip');
16-
1712
var inherits = require('util').inherits;
1813
var Transform = require('readable-stream').Transform;
1914

@@ -54,16 +49,6 @@ var Archiver = module.exports = function(format, options) {
5449
};
5550

5651
this._streams = [];
57-
58-
if (format === 'zip') {
59-
// this.use(pzip());
60-
} else if (format === 'tar') {
61-
// this.use(ptar());
62-
} else if (format === 'json') {
63-
this.use(pjson());
64-
} else {
65-
this.emit(error, new Error('no format plugin'));
66-
}
6752
};
6853

6954
inherits(Archiver, Transform);
@@ -514,7 +499,7 @@ Archiver.prototype.finalize = function() {
514499
return this;
515500
};
516501

517-
// needs to be deprecated
502+
// needs to be deprecated in 0.16/removed in 0.17
518503
Archiver.prototype.setFormat = function(format) {
519504
if (this._format) {
520505
this.emit('error', new Error('format: archive format already set'));
@@ -526,7 +511,7 @@ Archiver.prototype.setFormat = function(format) {
526511
return this;
527512
};
528513

529-
// needs to be deprecated
514+
// needs to be deprecated in 0.16/removed in 0.17
530515
Archiver.prototype.setModule = function(module) {
531516
if (this._state.aborted) {
532517
this.emit('error', new Error('module: archive was aborted'));

‎package.json

-3
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
"bench": "node benchmark/simple/pack-zip.js"
2929
},
3030
"dependencies": {
31-
"archiver-json": "~0.1.0",
32-
"archiver-tar": "~0.1.0",
33-
"archiver-zip": "~0.1.0",
3431
"async": "~1.4.2",
3532
"buffer-crc32": "~0.2.1",
3633
"glob": "~5.0.0",

0 commit comments

Comments
 (0)
Please sign in to comment.