Skip to content

Commit 150bb3e

Browse files
committedJun 5, 2015
tweak to custom data function check.
1 parent c0f3b86 commit 150bb3e

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed
 

‎lib/core.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,12 @@ Archiver.prototype.bulk = function(mappings) {
397397
}
398398

399399
try {
400-
entryData = dataFunction ? dataFunction(entryData) : entryData;
400+
if (dataFunction) {
401+
entryData = dataFunction(entryData);
401402

402-
if (dataFunction && typeof entryData !== 'object') {
403-
throw new Error('bulk: invalid data returned from custom function');
403+
if (typeof entryData !== 'object') {
404+
throw new Error('bulk: invalid data returned from custom function');
405+
}
404406
}
405407
} catch(e) {
406408
self.emit('error', e);
@@ -453,10 +455,12 @@ Archiver.prototype.directory = function(dirpath, destpath, data) {
453455
entryData.stats = file.stats;
454456

455457
try {
456-
entryData = dataFunction ? dataFunction(entryData) : entryData;
458+
if (dataFunction) {
459+
entryData = dataFunction(entryData);
457460

458-
if (dataFunction && typeof entryData !== 'object') {
459-
throw new Error('directory: invalid data returned from custom function');
461+
if (typeof entryData !== 'object') {
462+
throw new Error('directory: invalid data returned from custom function');
463+
}
460464
}
461465
} catch(e) {
462466
self.emit('error', e);

0 commit comments

Comments
 (0)