Make @apollo/client/testing a fully-fledged, independent entry point
#8769
+70
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added
2021-09
👩🏭 refactor
🔬 testing-utilities
🛠 tooling
🥚 backwards-compatible
benjamn
force-pushed
the
make-@apollo/client/testing-an-entry-point
branch
from
5a7f60c to
13f7e7b
Compare
benjamn
added a commit
that referenced
this pull request
Sep 10, 2021
#8687 (comment) Until now, the `@apollo/client/testing` entry point has merely re-exported the contents of `@apollo/client/utilities/testing`, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build. This commit moves the contents of `@apollo/client/utilities/testing` to reside within `@apollo/client/testing`, which should be safe because `@apollo/client/testing` was the only safe way to access these modules previously.
benjamn
force-pushed
the
make-@apollo/client/testing-an-entry-point
branch
from
9861f01 to
bc9f401
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8687 (comment).
Until now, the
@apollo/client/testingentry point has merely re-exported the contents of@apollo/client/utilities/testing, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build.This commit moves the contents of
@apollo/client/utilities/testingto reside within@apollo/client/testing, which should be safe because@apollo/client/testingwas the only safe way to access these modules previously.