THRIFT-5350 char is unsigned on non-x86 arches, use signed char to avoid compiler warning about always true comparisons

opoplawski · Jens-G · commit 011eb22e32ee · 2021-02-17T19:53:04.000+01:00
Patch: Orion Poplawski This closes #2331
diff --git a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc
@@ -1062,7 +1062,7 @@ std::string t_delphi_generator::make_pascal_string_literal(std::string value) {
   }
 
   result << "'";
-  for (char const &c: value) {
+  for (signed char const c: value) {
     if( (c >= 0) && (c < 32)) {  // convert ctrl chars, but leave UTF-8 alone
       result << "#" << (int)c;  
     } else if (c == '\'') {

Original file line number	Diff line number	Diff line change
`@@ -1062,7 +1062,7 @@ std::string t_delphi_generator::make_pascal_string_literal(std::string value) {`
`1062`	`1062`	`}`
`1063`	`1063`
`1064`	`1064`	`result << "'";`
`1065`		`- for (char const &c: value) {`
	`1065`	`+ for (signed char const c: value) {`
`1066`	`1066`	`if( (c >= 0) && (c < 32)) { // convert ctrl chars, but leave UTF-8 alone`
`1067`	`1067`	`result << "#" << (int)c;`
`1068`	`1068`	`} else if (c == '\'') {`