Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): avoid solid ripples in buttons #28717

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

crisbeto
Copy link
Member

The changes from #28664 appear to have caused ripples to be solid in some setups. These changes add a fallback to the old behavior if that's the case.

Fixes #28706.

The changes from angular#28664 appear to have caused ripples to be solid in some setups. These changes add a fallback to the old behavior if that's the case.

Fixes angular#28706.
@crisbeto crisbeto added the target: rc This PR is targeted for the next release-candidate label Mar 13, 2024
@crisbeto crisbeto requested a review from devversion March 13, 2024 08:30
@crisbeto crisbeto requested a review from mmalerba as a code owner March 13, 2024 08:30
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 13, 2024
@crisbeto crisbeto removed the request for review from mmalerba March 13, 2024 15:31
@crisbeto crisbeto self-assigned this Mar 13, 2024
@crisbeto crisbeto merged commit 438ff93 into angular:main Mar 13, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Mar 13, 2024
The changes from #28664 appear to have caused ripples to be solid in some setups. These changes add a fallback to the old behavior if that's the case.

Fixes #28706.

(cherry picked from commit 438ff93)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(COMPONENT): Angular Material custom theme button ripple is white when clicked
2 participants