Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slider): fix animation issue #28704

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(material/slider): fix animation issue #28704

merged 1 commit into from
Mar 11, 2024
+5 −0

Conversation

wagnermaciel
Copy link
Contributor

  • the slider track animation would break in the case where a user clicks one thumb, tabs to the other, then uses an arrow key to change value.
  • for some reason, this bug only happens when the slider is not discrete.

@wagnermaciel
fix(material/slider): fix animation issue
Loading
Loading status checks…
561ce28 
* the slider track animation would break in the case where
  a user clicks one thumb, tabs to the other, then uses an
  arrow key to change value.
* for some reason, this bug only happens when the slider is
  not discrete.
@wagnermaciel wagnermaciel marked this pull request as ready for review March 8, 2024 23:17
@wagnermaciel wagnermaciel requested a review from devversion as a code owner March 8, 2024 23:17
@wagnermaciel wagnermaciel requested a review from crisbeto March 8, 2024 23:19
@wagnermaciel
Copy link
Contributor Author

Here is a quick demo of the bug with animations reduced to 10% speed

Screen.Recording.2024-03-08.at.6.21.14.PM.mov

@wagnermaciel wagnermaciel removed the request for review from devversion March 11, 2024 14:53
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 11, 2024
@wagnermaciel wagnermaciel merged commit 27cb903 into angular:main Mar 11, 2024
26 of 28 checks passed
wagnermaciel added a commit that referenced this pull request Mar 11, 2024
@wagnermaciel
fix(material/slider): fix animation issue (#28704)
Loading
Loading status checks…
78bc47c 
* the slider track animation would break in the case where
  a user clicks one thumb, tabs to the other, then uses an
  arrow key to change value.
* for some reason, this bug only happens when the slider is
  not discrete.

(cherry picked from commit 27cb903)
wagnermaciel added a commit that referenced this pull request Mar 11, 2024
@wagnermaciel
fix(material/slider): fix animation issue (#28704)
Loading
Loading status checks…
386f768 
* the slider track animation would break in the case where
  a user clicks one thumb, tabs to the other, then uses an
  arrow key to change value.
* for some reason, this bug only happens when the slider is
  not discrete.

(cherry picked from commit 27cb903)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wagnermaciel @crisbeto