fix(material/schematics): AsyncPipe and NgIF not imported #28055
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Nov 5, 2023
| @@ -26,7 +27,8 @@ import { map, shareReplay } from 'rxjs/operators'; | |||
| MatButtonModule, | |||
| MatSidenavModule, | |||
| MatListModule, | |||
| MatIconModule | |||
| MatIconModule, | |||
| CommonModule | |||
There was a problem hiding this comment.
This should import the AsyncPipe from @angular/common, rather than the CommonModule.
There was a problem hiding this comment.
But also the NgIf is used.
Should we add it or just use the CommonModule as usual?
There was a problem hiding this comment.
We should do NgIf since we don't need the entire module.
There was a problem hiding this comment.
Code updated as discussed
fdonzello
changed the title
fdonzello
changed the title
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ng generate @angular/material:navigation navigation, theasyncPipeis used in the generated template but never imported into the Standalone Component imports.While the
AsyncPipeshould be imported to fix the issue, the*ngIfis also used in the template (even though I think this disappears when the new control flow syntax adoption is finalized).The fix proposes to import the
CommonModuleas we usually do when working with Standalone Components.