feat(google-maps): allow for info window focus behavior to be customized #23831
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
| @@ -168,7 +168,7 @@ export class MapInfoWindow implements OnInit, OnDestroy { | |||
| * Opens the MapInfoWindow using the provided anchor. If the anchor is not set, | |||
| * then the position property of the options input is used instead. | |||
| */ | |||
| open(anchor?: MapAnchorPoint) { | |||
| open(anchor?: MapAnchorPoint, shouldFocus?: boolean) { | |||
There was a problem hiding this comment.
Just a suggestion: I'm wondering if we should pass these things through an object literal, making the API more readable when more options are added? I find it generally more clear like open({shouldFocus: false}), than open(undefined, false)
There was a problem hiding this comment.
Changing it to an object literal would be a breaking change at this point. We could support both syntaxes for a while, but I don't think it's a big deal considering that there are only two parameters.
There was a problem hiding this comment.
FWIW I also would prefer an object here (with backwards compat), but don't feel strongly enough to block the change
|
@crisbeto After running a google3 presubmit, it looks like our internal version of the the Google Maps typings is out of date. The |
andrewseguin
removed
the
cla: yes
|
@googlebot: rescan |
googlebot
added
the
cla: yes
andrewseguin
removed
the
cla: yes
Allows for the `shouldFocus` flag to be passed when opening the info window. Fixes angular#23829.
crisbeto
force-pushed
the
23829/info-window-focus
branch
from
ddc3d1d to
21fca4e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for the
shouldFocusflag to be passed when opening the info window.Fixes #23829.