Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/tabs): label & body classes #23691

Merged
merged 1 commit into from
Jan 15, 2022
Merged

feat(material/tabs): label & body classes #23691

merged 1 commit into from
Jan 15, 2022
+201 −23

Conversation

lekhmanrus
Copy link
Contributor

closes #23685, #9290, #15997

@lekhmanrus lekhmanrus requested review from andrewseguin and a team as code owners October 5, 2021 16:58
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2021
@lekhmanrus lekhmanrus requested a review from crisbeto as a code owner October 5, 2021 17:22
@lekhmanrus lekhmanrus force-pushed the tabs-classes branch 4 times, most recently from b6fbd97 to d9ed100 Compare October 5, 2021 20:32
crisbeto
crisbeto reviewed Oct 6, 2021
View reviewed changes
crisbeto
crisbeto reviewed Oct 7, 2021
View reviewed changes
crisbeto
crisbeto approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Oct 7, 2021
@devversion devversion removed the request for review from a team November 5, 2021 12:56
@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Nov 19, 2021
@josephperrott
Copy link
Member

@lekhmanrus Hey, it looks like your PR has fallen out of date, please rebase the PR.

@lekhmanrus
Copy link
Contributor Author

@josephperrott done

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2021
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@andrewseguin andrewseguin merged commit f10d245 into angular:master Jan 15, 2022
This was referenced Jan 27, 2022
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

@andrewseguin andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Customize Css Class to the Mat-Tab-Content and other Mat-X tags which are generated runtime
4 participants
@lekhmanrus @josephperrott @crisbeto @andrewseguin