Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/components
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f3783b7b5fd8b7593502086e3cc827b46f45fe83
Choose a base ref
...
head repository: angular/components
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 13a8a2340b1aa6c3174c11c54c9c3d459956a4c2
Choose a head ref

Commits on Feb 7, 2024

  1. Copy the full SHA
    3e7bfc2 View commit details
  2. Copy the full SHA
    af7cd70 View commit details
  3. test: Ensure M3 theme is well behaved (#28555)

    Specifically it should:
    1. Only emit styles under the user specified selector
    2. Only emit CSS variable definitions
    mmalerba authored Feb 7, 2024
    Copy the full SHA
    0499dc0 View commit details

Commits on Feb 8, 2024

  1. fix(material/tabs): prevent page scroll on space press (#28532)

    This appears to be a regression from #27862 where the `preventDefault` was removed both from space and enter presses. We still need it on space so that the page doesn't scroll.
    
    Fixes #28392.
    crisbeto authored Feb 8, 2024
    Copy the full SHA
    556bcc3 View commit details
  2. fix(material/menu): prevent icon from collapsing when text is long (#…

    …28541)
    
    Fixes that the icon the menu item was collapsing if the menu item text was too long.
    
    Fixes #28502.
    crisbeto authored Feb 8, 2024
    Copy the full SHA
    a3b28df View commit details
  3. fix(material/list): indexOf usage incorreect for active focus reset (#…

    …28531)
    
    The buggy logic was using a truthiness check for checking for presence
    in a list, but this check needed to compare against -1 instead.  This
    corrects a mismanagement of tabIndex on the items in the selection
    list: if the list of items changed, the selection list could not
    be tab selected until the selection list was mouse-focused.
    dyoo authored Feb 8, 2024
    Copy the full SHA
    f1e82da View commit details
  4. fix(cdk/table): error if outlets are assigned too early (#28551)

    Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.
    
    Fixes #28538.
    crisbeto authored Feb 8, 2024
    Copy the full SHA
    add3cd4 View commit details
  5. feat(google-maps): add advanced marker (#28525)

    * feat(google-maps): add advanced marker
    
    This commit introduces the advanced-marker feature to the map package, enabling users to add custom, interactive markers to their maps.
    
    Related #25897
    
    * feat(google-maps): remove default value for mapId and correct z-index description property for advanced markers
    
    * feat(google-maps): generate api report file for google-maps
    OgiSss authored Feb 8, 2024
    Copy the full SHA
    b4b91be View commit details
  6. docs(material/list): add example of line scenarios with checkbox

    Add example of line scenarios with checkbox.
    zarend committed Feb 8, 2024
    Copy the full SHA
    f3e487d View commit details
  7. fix(material/list): tokenize space around leading icon

    List component: tokenize space on left and right of leading icon.
    
    Correct spacing around leading icon on M3. Currently, leading icon has
    16px margin in front of icon and 32px behind. Give leading icon
    symmetrical margin for M3.
    
    Does not intend to make visual change to M2.
    zarend committed Feb 8, 2024
    Copy the full SHA
    c88c598 View commit details
  8. Copy the full SHA
    ca5d0f1 View commit details

Commits on Feb 9, 2024

  1. refactor(material/core): remove private APIs from root export (#28533)

    Removes a bunch of private APIs that were re-exported from the root so that they can be reused in the legacy components.
    
    Fixes #28297.
    crisbeto authored Feb 9, 2024
    Copy the full SHA
    3f08925 View commit details
  2. Copy the full SHA
    e8bfb86 View commit details
  3. fix(material/form-field): container height in lower densities (#28546)

    * The 12px padding being applied to the mat-icon was preventing
      the form-field container height from condensing in lower densities.
    wagnermaciel authored Feb 9, 2024
    Copy the full SHA
    e5870e9 View commit details
  4. fix(material-experimental/theming): Add more tests for M3 theme tokens (

    #28561)
    
    Additional tests that help ensure our M3 theme conforms to the following
    rules:
    - Does not add any additional selector specificity
    - Emits only CSS variable definitions
    - Emits each token for one and only one theme dimension
    
    Also fixes several existing bugs that were discovered by the new tests.
    mmalerba authored Feb 9, 2024
    Copy the full SHA
    acf72e1 View commit details
  5. fix(material/datepicker): fix M3 styles (#28556)

    * fix(material/datepicker): fix M3 styles
    
    * fix(material/datepicker): fix m2 text button color
    andrewseguin authored Feb 9, 2024
    Copy the full SHA
    206f0fc View commit details
  6. Copy the full SHA
    9a16aa1 View commit details
  7. Copy the full SHA
    78a292b View commit details

Commits on Feb 12, 2024

  1. fix(material/progress-bar): incorrect alignment if direction is set o…

    …n element
    
    Fixes an issue where the progress bar was looking for `dir="rtl"` only on parent elements, but on itself. We can avoid the problem altogether by using a directionality-agnostic property.
    
    Fixes #28572.
    crisbeto committed Feb 12, 2024
    Copy the full SHA
    d0618bc View commit details
  2. fix(material/datepicker): use direction-agnostic text-align

    Avoids some extra styles by using `text-align: start` instead of having to flip it manually for RTL.
    crisbeto committed Feb 12, 2024
    Copy the full SHA
    27df9cf View commit details
  3. fix(material/list): use direction-agnostic text-align

    Avoids some extra styles by using `text-align: start` instead of having to flip it manually for RTL.
    crisbeto committed Feb 12, 2024
    Copy the full SHA
    4f518f9 View commit details
  4. build: minor improvement to dev app density toggling (#28571)

    Fixes a minor gripe where the density tooltip closes when the button is pressed so the user needs to re-focus to see which density is currently active.
    crisbeto authored Feb 12, 2024
    Copy the full SHA
    66d0f2d View commit details
  5. build: ensure component owners are assigned to public API changes (#2…

    …8573)
    
    Currently everything under `/tools` is set to be owned by dev infra which means that if a public API golden doesn't have an owner, it falls back to dev infra. These changes assign all directories in `tools` *except* the goldens to dev infra so that the owners linting can pick up any missing files.
    
    I've also redistributed the public API golden owners so they match the component owners, and I've added myself to the owners for the Tslint and Stylelint rules.
    crisbeto authored Feb 12, 2024
    Copy the full SHA
    7294c6e View commit details
  6. docs(material/list): fix m3 demo trailing icon color (#28580)

    Fix trailing icon color in M3 List demo. Fix icon color by removing
    style override in List demo.
    zarend authored Feb 12, 2024
    Copy the full SHA
    83b6ebc View commit details

Commits on Feb 13, 2024

  1. fix(material/slide-toggle): m3 track outline and handle opacity (#28565)

    * fix(material/slide-toggle): m3 track outline
    
    * fix(material/slide-toggle): m3 disabled handle color and opacity
    
    * fix(material/slide-toggle): wrap hardcoded custom tokens
    
    * fixup! fix(material/slide-toggle): m3 track outline
    wagnermaciel authored Feb 13, 2024
    Copy the full SHA
    0153667 View commit details
  2. fix(material/list): ensure leading icon scales with token

    Correct the font size of leading icon in List component. Set font-size of
    leading icon to same value as its width and height. Ensure Ensure icon scales to
    "list-item-leading-icon-size" token.
    
    Fix icon with cut-off appearance when "list-item-leading-icon-size" is less than
    24px.
    zarend committed Feb 13, 2024
    Copy the full SHA
    581e42f View commit details
  3. fix(material/list): match leading icon size in M3 to spec

    Increase size of the leading icon in M3 List to 24px. Match spec, which has list-item-leading-icon-size of 24px. Current version of tokens (0_161) has 18px.
    
    Does not affect M2 List.
    zarend committed Feb 13, 2024
    Copy the full SHA
    fac45f3 View commit details
  4. Copy the full SHA
    296c948 View commit details
  5. fix(cdk/listbox): unable to tab in if active option is removed (#28583)

    Fixes that the listbox didn't allow focus back in when its active option is removed.
    
    Fixes #28557.
    crisbeto authored Feb 13, 2024
    Copy the full SHA
    d766b14 View commit details
  6. fix(material/datepicker): fix touchui shadow and border-radius (#28577)

    * fix(material/datepicker): fix touchui shadow and border-radius
    
    * fix(material/datepicker): fix lint
    andrewseguin authored Feb 13, 2024
    Copy the full SHA
    7524b89 View commit details
  7. Copy the full SHA
    17498f5 View commit details

Commits on Feb 14, 2024

  1. build: reduce implicit timeouts in webdriver test (#28589)

    Attempt at deflaking the e2e tests by reducing the implicit timeout.
    crisbeto authored Feb 14, 2024
    Copy the full SHA
    b26fe35 View commit details
  2. Copy the full SHA
    208fab2 View commit details
  3. Copy the full SHA
    cb3192d View commit details
  4. Copy the full SHA
    1a1929d View commit details
  5. Copy the full SHA
    11694c3 View commit details
  6. fix(material/list): tokenize active-indicator (#28586)

    * fix(material/list): tokenize active-indicator
    
    Add active state for MatNavList. Implement active state by implementing 2
    tokens under mat prefix.
    
     - mat-list-active-indicator-color
     - mat-list-active-indicator-shape
    
    Only affects list items that are anchor tags.
    
    Does not intend to make visual changes to M2.
    
    * !fixup fix(material/list): tokenize active-indicator
    zarend authored Feb 14, 2024
    Copy the full SHA
    09ee075 View commit details
  7. Copy the full SHA
    ba57666 View commit details

Commits on Feb 15, 2024

  1. refactor(material/paginator): remove TypeScript mixin usages

    Replaces the final usage of TypeScript mixins in the paginator.
    crisbeto committed Feb 15, 2024
    3
    Copy the full SHA
    e13ece1 View commit details
  2. refactor(material/sort): remove TypeScript mixin usages

    Replaces the final usage of TypeScript mixins in the sort header.
    crisbeto committed Feb 15, 2024
    Copy the full SHA
    facd027 View commit details

Commits on Feb 21, 2024

  1. fix(cdk/listbox): make typeahead label nullable (#28602)

    Allows the `cdkOptionTypeaheadLabel` to be set to a nullable value.
    
    Fixes #28464.
    crisbeto authored Feb 21, 2024
    Copy the full SHA
    d1d1d02 View commit details
  2. fix(google-maps): mapId not being set

    Fixes that the `mapId` input wasn't being passed along to the map.
    
    Fixes #28608.
    crisbeto committed Feb 21, 2024
    Copy the full SHA
    5269e0f View commit details
  3. fix(google-maps): advanced marker not destroyed

    Fixes that the advanced marker wasn't being removed from the map on destroy.
    
    Fixes #28609.
    crisbeto committed Feb 21, 2024
    Copy the full SHA
    cc618b4 View commit details
  4. fix(material/expansion): center indicator icon in M3 (#28603)

    Currently the expansion panel arrow is drawn with borders which makes it difficult to center. It's also problematic in high contrast mode where it renders as a rectangle. We've wanted to fix this for a while, but it breaks a lot of internal screenshot tests (see #10503).
    
    These changes resolve the issue for apps using M3 by having two indicators that we toggle using tokens.
    
    Fixes #28037.
    crisbeto authored Feb 21, 2024
    Copy the full SHA
    31102d0 View commit details
  5. refactor(material/tabs): remove mixin function (#28606)

    Replaces a usage of a mixin function in the tabs with a base class.
    crisbeto authored Feb 21, 2024
    Copy the full SHA
    f44c5aa View commit details
  6. fix(cdk/overlay): only emit positionChanges when position is different

    Currently we emit the `positionChanges` event whenever a position is recalculcated which can be on each scroll event. These changes switch to doing so only if either the actual position or the scrolled state has changed.
    crisbeto committed Feb 21, 2024
    Copy the full SHA
    01cc6f3 View commit details
  7. fix(cdk/overlay): run positionChange event inside the zone

    Fixes that the `positionChange` event of the `CdkConnectedOverlay` directive was running outside the zone.
    
    Fixes #28568.
    crisbeto committed Feb 21, 2024
    Copy the full SHA
    b513b50 View commit details

Commits on Feb 22, 2024

  1. Copy the full SHA
    b8b86f7 View commit details
  2. Copy the full SHA
    d361f79 View commit details
  3. refactor(cdk/table): remove mixin function usages

    Removes the final usages of TypeScript mixins in the CDK table by adding the sticky functionality to the individual usages. Ideally we'd have a base class for this, but that won't be usable in `CdkHeaderRowDef` and `CdkFooterRowDef` because they already inherit from `BaseRowDef` and we can't put the sticky functionality there, because `CdkRowDef` shouldn't support `sticky`. The logic is pretty basic so I think it's fine to duplicate it.
    crisbeto committed Feb 22, 2024
    Copy the full SHA
    f260aa0 View commit details
Showing 561 changed files with 4,608 additions and 1,862 deletions.
73 changes: 57 additions & 16 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
/src/material/checkbox/** @mmalerba
/src/material/chips/** @mmalerba @crisbeto @zarend
/src/material/datepicker/** @mmalerba @crisbeto @zarend
/src/material/dialog/** @devversion
/src/material/dialog/** @devversion @crisbeto
/src/material/divider/** @andrewseguin @crisbeto
/src/material/expansion/** @andrewseguin
/src/material/form-field/** @devversion @mmalerba
@@ -212,54 +212,95 @@
/.yarn/** @devversion @josephperrott
/scripts/** @devversion @josephperrott
/test/** @devversion @josephperrott
/tools/** @devversion @josephperrott
/tools/* @devversion @josephperrott
/tools/angular/** @devversion @josephperrott
/tools/dgeni/** @devversion @josephperrott
/tools/example-module/** @devversion @josephperrott
/tools/highlight-files/** @devversion @josephperrott
/tools/markdown-to-html/** @devversion @josephperrott
/tools/mdc-deps/** @devversion @josephperrott
/tools/package-docs-content/** @devversion @josephperrott
/tools/postcss/** @devversion @josephperrott
/tools/postinstall/** @devversion @josephperrott
/tools/region-parser/** @devversion @josephperrott
/tools/release-checks/** @devversion @josephperrott
/tools/sass/** @devversion @josephperrott
/tools/server-test/** @devversion @josephperrott
/tools/stylelint/** @devversion @josephperrott @crisbeto
/tools/tslint-rules/** @devversion @josephperrott @crisbeto

# Only the root of the API guard, the rest of the files
# should be distributed among the component owners.
/tools/public_api_guard/* @devversion @josephperrott

# Public API golden files
/tools/public_api_guard/cdk/* @andrewseguin
/tools/public_api_guard/cdk/a11y** @jelbourn @devversion
/tools/public_api_guard/cdk/accordion** @andrewseguin
/tools/public_api_guard/cdk/bidi** @andrewseguin
/tools/public_api_guard/cdk/cdk** @andrewseguin
/tools/public_api_guard/cdk/clipboard** @andrewseguin
/tools/public_api_guard/cdk/coercion** @andrewseguin
/tools/public_api_guard/cdk/collections** @crisbeto @andrewseguin
/tools/public_api_guard/cdk/dialog** @jelbourn @crisbeto
/tools/public_api_guard/cdk/drag-drop** @crisbeto
/tools/public_api_guard/cdk/keycodes** @andrewseguin
/tools/public_api_guard/cdk/layout** @andrewseguin
/tools/public_api_guard/cdk/listbox** @jelbourn
/tools/public_api_guard/cdk/menu** @mmalerba @crisbeto
/tools/public_api_guard/cdk/observers** @andrewseguin @crisbeto
/tools/public_api_guard/cdk/overlay** @andrewseguin @crisbeto
/tools/public_api_guard/cdk/overlay** @jelbourn @crisbeto
/tools/public_api_guard/cdk/platform** @andrewseguin @devversion
/tools/public_api_guard/cdk/portal** @andrewseguin
/tools/public_api_guard/cdk/schematics** @devversion @andrewseguin
/tools/public_api_guard/cdk/scrolling** @andrewseguin @crisbeto
/tools/public_api_guard/cdk/stepper** @mmalerba
/tools/public_api_guard/cdk/table** @andrewseguin
/tools/public_api_guard/cdk/testing** @mmalerba @devversion
/tools/public_api_guard/cdk/text-field** @mmalerba
/tools/public_api_guard/cdk/tree** @jelbourn @andrewseguin
/tools/public_api_guard/google-maps/** @crisbeto

/tools/public_api_guard/material/* @andrewseguin
/tools/public_api_guard/material/autocomplete** @crisbeto
/tools/public_api_guard/material/badge** @andrewseguin
/tools/public_api_guard/material/bottom-sheet** @andrewseguin @crisbeto
/tools/public_api_guard/material/badge** @jelbourn
/tools/public_api_guard/material/bottom-sheet** @jelbourn @crisbeto
/tools/public_api_guard/material/button-toggle** @andrewseguin
/tools/public_api_guard/material/chips** @andrewseguin
/tools/public_api_guard/material/chips/testing** @andrewseguin
/tools/public_api_guard/material/core** @andrewseguin
/tools/public_api_guard/material/button** @andrewseguin
/tools/public_api_guard/material/card** @mmalerba
/tools/public_api_guard/material/checkbox** @mmalerba
/tools/public_api_guard/material/chips** @mmalerba @crisbeto @zarend
/tools/public_api_guard/material/datepicker** @mmalerba @crisbeto @zarend
/tools/public_api_guard/material/dialog** @devversion @crisbeto
/tools/public_api_guard/material/divider** @andrewseguin @crisbeto
/tools/public_api_guard/material/expansion** @andrewseguin
/tools/public_api_guard/material/form-field** @mmalerba
/tools/public_api_guard/material/form-field** @devversion @mmalerba
/tools/public_api_guard/material/grid-list** @andrewseguin
/tools/public_api_guard/material/icon** @andrewseguin
/tools/public_api_guard/material/list** @andrewseguin @crisbeto @devversion
/tools/public_api_guard/material/material** @andrewseguin
/tools/public_api_guard/material/input** @devversion @mmalerba
/tools/public_api_guard/material/list** @mmalerba @devversion
/tools/public_api_guard/material/menu** @crisbeto
/tools/public_api_guard/material/radio** @andrewseguin @devversion
/tools/public_api_guard/material/paginator** @crisbeto
/tools/public_api_guard/material/prebuilt-themes** @andrewseguin
/tools/public_api_guard/material/progress-bar** @andrewseguin
/tools/public_api_guard/material/progress-spinner** @andrewseguin
/tools/public_api_guard/material/radio** @mmalerba
/tools/public_api_guard/material/schematics** @devversion @andrewseguin
/tools/public_api_guard/material/select** @crisbeto
/tools/public_api_guard/material/select** @crisbeto
/tools/public_api_guard/material/sidenav** @mmalerba
/tools/public_api_guard/material/slider** @mmalerba
/tools/public_api_guard/material/slide-toggle** @crisbeto
/tools/public_api_guard/material/slider** @devversion
/tools/public_api_guard/material/snack-bar** @andrewseguin
/tools/public_api_guard/material/sort** @andrewseguin
/tools/public_api_guard/material/stepper** @mmalerba
/tools/public_api_guard/material/table** @andrewseguin
/tools/public_api_guard/material/tabs** @crisbeto
/tools/public_api_guard/material/testing** @andrewseguin
/tools/public_api_guard/material/toolbar** @devversion
/tools/public_api_guard/material/tooltip** @andrewseguin
/tools/public_api_guard/material/tree** @jelbourn @andrewseguin
/tools/public_api_guard/youtube-player/** @andrewseguin

/tools/public_api_guard/youtube-player/** @crisbeto
/tools/public_api_guard/google-maps/** @crisbeto

# Misc
/.github/** @devversion @josephperrott
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -265,7 +265,7 @@ jobs:
- name: Build and create package artifacts
run: ./scripts/create-package-archives.js --suffix "pr${{github.event.number}}-$(git rev-parse --short HEAD)"
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # tag=v4.3.1
with:
name: Package Artifacts
path: dist/release-archives
1 change: 1 addition & 0 deletions .ng-dev/google-sync-config.json
Original file line number Diff line number Diff line change
@@ -33,6 +33,7 @@
"src/material/core/theming/tests/**/*",
"src/material/core/tokens/tests/**",
"src/material/expansion/index.ts",
"src/material-experimental/theming/_format-tokens.scss",
"**/*import.scss"
]
}
Loading