feat(ts): expose built files in umd #4844
Merged
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be achieved using the dtsRollup feature of api-extractor, which isn't needed for the es build, as local files work perfectly fine in that case. Make sure to check the generated files when reviewing this PR
Haroenv
requested review from
a team,
eunjae-lee and
francoischalifour
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c0279c:
|
|
https://codesandbox.io/s/instantsearch-js-forked-34p6s?file=/src/app.js proves that it works 🙌 |
eunjae-lee
reviewed
Aug 23, 2021
| ); | ||
| shell.cp( | ||
| path.join(__dirname, '../../dist/instantsearch.production.d.ts'), | ||
| path.join(__dirname, '../../dist/instantsearch.development.min.d.ts') |
There was a problem hiding this comment.
in which case do people need development.d.ts file?
There was a problem hiding this comment.
all the files are the same, but typescript works by matching a .d.ts file to a .js file, so if you're importing /dist/development.min.js then the .d.ts is needed for that to work
eunjae-lee
approved these changes
Aug 23, 2021
francoischalifour
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the entry point for umd for each of the umd entry points.
This is achieved using the dtsRollup feature of api-extractor, which isn't needed for the es build, as local files work perfectly fine in that case.
Make sure to check the generated files when reviewing this PR
Result
A situation like algolia/create-instantsearch-app#464 is done easier by simply declaring what's import from the umd