fix(sendEvent): split > 20 objects in multiple calls #4841
Merged
+381
−182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the backend api doesn't allow > 20 hits per event, so we split the sendEvent calls up into multiple if > 20 DX-2379
Result
edited sendEvent and bindEvent to both split up the vents in arrays where it makes sense, and calling sendEvent multiple times.
We choose to split at this level and not inside the events listener, as you can't know what method is used, and you'd need a lot of conditional code to handle all chunking