fix(types): export all types as "type" to avoid exporting in .js #4837
+723
−610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 807986f:
|
This comment has been minimized.
This comment has been minimized.
3 tasks
Haroenv
requested review from
a team,
eunjae-lee and
tkrugg
and removed request for
a team
Haroenv
force-pushed
the
fix/type-exports
branch
3 times, most recently
from
950c019 to
59f0811
Compare
This issue is caused by `export * from './types'` added in #4834, which causes everything in /types to be exposed, but unfortunately because `export from` in the InstantSearch file mixed a type and a value, and thus exported it. This is done by enabling [consistent-type-imports](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) in eslint to make sure it's correct in all cases references: - code that throws: https://unpkg.com/browse/instantsearch.js@4.27.1/es/types/instantsearch.js - vite reproduction: https://github.com/eunjae-lee/vue-instantsearch-with-vue3-and-vite
Haroenv
force-pushed
the
fix/type-exports
branch
from
59f0811 to
1870e74
Compare
eunjae-lee
approved these changes
Aug 18, 2021
this catches when you export something that's a type as a regular export, further avoiding the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue is caused by
export * from './types'added in #4834, which causes everything in /types to be exposed, but unfortunately becauseexport fromin the InstantSearch file mixed a type and a value, and thus exported it.This is done by enabling consistent-type-imports in eslint to make sure it's correct in all cases
references:
Result
all type imports are actually
import typeorexport typenow