Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): export widget's types #4813

Merged
merged 2 commits into from
Jul 19, 2021
Merged

fix(types): export widget's types #4813

merged 2 commits into from
Jul 19, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jul 19, 2021

Summary

Not all widgets export their type correctly, which means it is harder to use

Result

all types are exported from their respective file for widgets, not yet from the indexes

@Haroenv Haroenv requested review from tkrugg, a team and eunjae-lee and removed request for a team July 19, 2021 09:52
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ab1196:

Sandbox Source
InstantSearch.js Configuration

@Haroenv Haroenv merged commit e9764e9 into master Jul 19, 2021
@Haroenv Haroenv deleted the fix/types-widget-export branch July 19, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants