fix(build): ensure build fails when types building fails #4812
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment failing build types are not being surfaced to circle ci. See for example this build, step
Trigger a release if the latest commit is a release commit
should have failed but it didn't.This is because
yarn built:types
is run viashell.exec
and the return code of 1 is ignored, instead of passed to calling process.Per exec docs, it's the caller's reponsibility to read the exit code and exit or continue.
This change would effectively make sure that
scripts/release/build-experimental-typescript.js
return code 1 if any of the exec inside do.NB:
exec
is also called in other areas but in this case, it's not fromshelljs
but the one in shipjs-lib which reads and throws when code is 1.