fix(sortBy): do not write the default state #4798
Merged
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, if a route state is read (eg. in ssr) with the default value, it will be persisted in the URL, as the refinement is the default refinement, and the ui state was kept as-is, instead of being cleared. fixes algolia/vue-instantsearch#1005
Haroenv
requested review from
a team,
tkrugg and
francoischalifour
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6caebb6:
|
Haroenv
requested review from
eunjae-lee
and removed request for
francoischalifour
|
I think I understand the issue partially. How can I reproduce the issue on my own? CleanShot.2021-06-28.at.15.49.32.mp4I don't understand the flow of the default state added to state. |
|
The default state gets added in Vue InstantSearch in server side rendering, not 100% sure how, but I can tell that it happens only then (see sandbox in linked issue) @eunjae-lee |
tkrugg
approved these changes
Jun 28, 2021
Haroenv
added a commit
that referenced
this pull request
Jul 1, 2021
Without this check, if a route state is read (eg. in ssr) with the default value, it will be persisted in the URL, as the refinement is the default refinement, and the ui state was kept as-is, instead of being cleared. fixes algolia/vue-instantsearch#1005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without this check, if a route state is read (eg. in ssr) with the default value, it will be persisted in the URL, as the refinement is the default refinement, and the ui state was kept as-is, instead of being cleared.
Result
fixes algolia/vue-instantsearch#1005