Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): convert rangeInput widget and component #4766

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Conversation

shortcuts
Copy link
Member

Summary

Converts rangeInput widget and RangeInput component to TypeScript.

@shortcuts shortcuts requested review from a team, tkrugg and Haroenv and removed request for a team May 31, 2021 09:23
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 31, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ccbe1d:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just one question about the added expect-error

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Haroenv Haroenv merged commit 40b1a82 into master Jun 2, 2021
@Haroenv Haroenv deleted the feat/ts-rangeInput branch June 2, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants