Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): convert poweredBy widget #4756

Merged
merged 6 commits into from
May 18, 2021
Merged

feat(ts): convert poweredBy widget #4756

merged 6 commits into from
May 18, 2021

Conversation

shortcuts
Copy link
Member

Summary

Converts poweredBy widget to TypeScript.

@shortcuts shortcuts requested review from a team, tkrugg and francoischalifour and removed request for a team May 14, 2021 13:37
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c93e7b4:

Sandbox Source
InstantSearch.js Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as Francois, fine for the rest!

@Haroenv Haroenv removed the request for review from tkrugg May 17, 2021 07:33
shortcuts and others added 3 commits May 17, 2021 16:59
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use cx twice :)

@shortcuts shortcuts merged commit 142660a into master May 18, 2021
@shortcuts shortcuts deleted the feat/ts-poweredBy branch May 18, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants