feat(widget): add access to "parent" in dispose #4745
Merged
+166
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5489f4e:
|
francoischalifour
approved these changes
Apr 22, 2021
shortcuts
approved these changes
Apr 23, 2021
Haroenv
force-pushed
the
chore/types-reorg-8
branch
from
e02ab36 to
28c74b8
Compare
Haroenv
force-pushed
the
feat/dispose-parent
branch
3 times, most recently
from
1f51034 to
2eac256
Compare
Haroenv
force-pushed
the
chore/types-reorg-8
branch
from
28c74b8 to
52bb7f1
Compare
Haroenv
force-pushed
the
feat/dispose-parent
branch
from
2eac256 to
6e158ba
Compare
Haroenv
force-pushed
the
chore/types-reorg-8
branch
from
52bb7f1 to
467df0e
Compare
Haroenv
force-pushed
the
feat/dispose-parent
branch
2 times, most recently
from
4b31be4 to
2e91a77
Compare
Haroenv
force-pushed
the
chore/types-reorg-8
branch
from
467df0e to
11c6b97
Compare
If the widget is conditionally adding widgets to the parent in init & render, it needs to be able to remove those on dispose.
Haroenv
force-pushed
the
feat/dispose-parent
branch
from
2e91a77 to
5489f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the widget is conditionally adding widgets to the parent in init & render, it needs to be able to remove those on dispose.
Result
disposeis called withparenttoo. Updated all tests to use the existing helpercreateDisposeOptions